fix: unify mixed-format tool block handling across task + condense#11417
Closed
daniel-lxs wants to merge 2 commits intomainfrom
Closed
fix: unify mixed-format tool block handling across task + condense#11417daniel-lxs wants to merge 2 commits intomainfrom
daniel-lxs wants to merge 2 commits intomainfrom
Conversation
Contributor
Re-reviewed after merge commit c1ab9ad. The merge with main adopted the
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_use/tool_result) and AI SDK (tool-call/tool-result) shapesTask,condense, andvalidateToolResultIdsto use shared helpers instead of duplicated local type guards/mappersWhy
Message history is currently a mix of legacy Anthropic and AI SDK shapes during migration. Prior logic handled these formats inconsistently across code paths, which risked orphan filtering mistakes and resume/protocol mismatches.
Testing
pnpm --dir src exec tsc --noEmit --pretty falsepnpm --dir src exec vitest run core/condense/__tests__/index.spec.ts core/task/__tests__/validateToolResultIds.spec.ts core/task/__tests__/Task.persistence.spec.ts core/task/__tests__/flushPendingToolResultsToHistory.spec.tsgit push