Skip to content

[Condense] Fix double counting last message when condensing #3763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canrobins13 merged 1 commit into from
May 20, 2025
Merged

[Condense] Fix double counting last message when condensing #3763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/core/task/Task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,16 +492,9 @@ export class Task extends EventEmitter<ClineEvents> {
if (!summary) {
return
}
const lastMessageContent = this.apiConversationHistory.at(-1)?.content
await this.overwriteApiConversationHistory(messages)
const { contextTokens } = this.getTokenUsage()
const lastContent =
typeof lastMessageContent === "string"
? [{ type: "text" as const, text: lastMessageContent }]
: lastMessageContent
const lastMessageTokens = lastContent ? await this.api.countTokens(lastContent) : 0
const prevContextTokens = contextTokens + lastMessageTokens
const contextCondense: ContextCondense = { summary, cost, newContextTokens, prevContextTokens }
const contextCondense: ContextCondense = { summary, cost, newContextTokens, prevContextTokens: contextTokens }
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the extra token count for the last message avoids double counting during manual condense, which is the intended fix. Consider adding a brief comment explaining that getTokenUsage() already accounts for the last message, so there's no need to add extra tokens.

await this.say(
"condense_context",
undefined /* text */,
Expand Down
Loading