Skip to content

feat: Refactor Gemini and Vertex handlers to be fully independent #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kiwina wants to merge 5 commits into from
Closed

feat: Refactor Gemini and Vertex handlers to be fully independent #4375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbcf56a
feat: add vertex API key support and refactor provider handlers
kiwina Jun 5, 2025
170ecaf
Add translations for providers.googleCloudApiKey in all locales
kiwina Jun 5, 2025
624cee1
Update webview-ui/src/i18n/locales/en/settings.json
kiwina Jun 5, 2025
9887181
Fix linting error in vertex test file
kiwina Jun 7, 2025
d6e6f13
Merge upstream main into vertex-apikey branch
kiwina Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/evals/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ To stop an evals run early you can simply stop the "controller" container using

<img width="1302" alt="Screenshot 2025-06-06 at 9 00 41 AM" src="https://github.com/user-attachments/assets/a9d4725b-730c-441a-ba24-ac99f9599ced" />


## Advanced Usage / Debugging

The evals system runs VS Code headlessly in Docker containers for consistent, reproducible environments. While this design ensures reliability, it can make debugging more challenging. For debugging purposes, you can run the system locally on macOS, though this approach is less reliable due to hardware and environment variability.
Expand Down
2 changes: 2 additions & 0 deletions packages/types/src/provider-settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ const bedrockSchema = apiModelIdProviderModelSchema.extend({
})

const vertexSchema = apiModelIdProviderModelSchema.extend({
vertexApiKey: z.string().optional(),
vertexKeyFile: z.string().optional(),
vertexJsonCredentials: z.string().optional(),
vertexProjectId: z.string().optional(),
Expand Down Expand Up @@ -290,6 +291,7 @@ export const PROVIDER_SETTINGS_KEYS = keysOf<ProviderSettings>()([
"awsBedrockEndpointEnabled",
"awsBedrockEndpoint",
// Google Vertex
"vertexApiKey",
"vertexKeyFile",
"vertexJsonCredentials",
"vertexProjectId",
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/providers/vertex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,4 +233,5 @@ export const VERTEX_REGIONS = [
{ value: "europe-west1", label: "europe-west1" },
{ value: "europe-west4", label: "europe-west4" },
{ value: "asia-southeast1", label: "asia-southeast1" },
{ value: "global", label: "global" },
]
Loading
Loading