-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: remove unused i18n keys for include max output tokens #6935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
hannesrudolph
wants to merge
2
commits into
main
from
chore/i18n-cleanup-include-max-output-tokens-6921
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
packages/types/src/providers/__tests__/openai.models.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import { describe, it, expect } from "vitest" | ||
| import { openAiNativeModels } from "../openai.js" | ||
|
|
||
| type Dict = Record<string, unknown> | ||
| const hasProp = (obj: Dict, key: string) => Object.prototype.hasOwnProperty.call(obj, key) | ||
| const boolProp = (obj: Dict, key: string): boolean | undefined => { | ||
| const v = obj[key] | ||
| return typeof v === "boolean" ? (v as boolean) : undefined | ||
| } | ||
|
|
||
| describe("openAiNativeModels temperature invariants", () => { | ||
| it("models with supportsTemperature === false must not specify defaultTemperature", () => { | ||
| const values = Object.values(openAiNativeModels) as Dict[] | ||
| for (const info of values) { | ||
| const supportsTemp = boolProp(info, "supportsTemperature") | ||
| if (supportsTemp === false) { | ||
| expect(hasProp(info, "defaultTemperature")).toBe(false) | ||
| } | ||
| } | ||
| }) | ||
|
|
||
| it("gpt-5 family models must have supportsTemperature: false and no defaultTemperature", () => { | ||
| const gpt5Ids = ["gpt-5-2025-08-07", "gpt-5-mini-2025-08-07", "gpt-5-nano-2025-08-07"] as const | ||
| for (const id of gpt5Ids) { | ||
| // Non-undefined assertion is safe here because the IDs are known keys in openAiNativeModels | ||
| const infoUnknown = (openAiNativeModels as Record<string, unknown>)[id]! | ||
| const info = infoUnknown as Dict | ||
| expect(info).toBeDefined() | ||
| expect(boolProp(info, "supportsTemperature")).toBe(false) | ||
| expect(hasProp(info, "defaultTemperature")).toBe(false) | ||
| } | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this test file change intentional for an i18n cleanup PR? While the improvements to type safety are good, they seem unrelated to removing unused translation keys. Consider moving these changes to a separate PR for clarity.