Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Aug 11, 2025

This PR reverts PR #6864 to prepare for splitting the changes into smaller, more manageable pull requests.

The original PR introduced multiple features and changes that would be better reviewed and merged separately.


Important

Reverts PR #6864, removing OpenAI provider and GPT-5 model features, including schema changes, test removals, and UI updates.

  • Behavior:
    • Reverts changes from PR GPT5 OpenAI Fix #6864, removing features related to OpenAI provider and GPT-5 models.
    • Removes GPT-5 specific handling in openai-native.ts and index.ts.
  • Schemas:
    • Removes metadata field from clineMessageSchema in message.ts.
    • Removes supportsVerbosity from modelInfoSchema in model.ts.
  • Tests:
    • Removes tests for GPT-5 models in openai-native.spec.ts.
  • UI:
    • Removes reasoning effort "minimal" option from provider-settings.ts and related UI components.
    • Updates i18n files to remove "minimal" reasoning effort option.

This description was created by Ellipsis for 6f86819. You can customize this summary. It will automatically update as commits are pushed.

@daniel-lxs daniel-lxs requested review from cte, jr and mrubens as code owners August 11, 2025 19:40
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Aug 11, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap Aug 11, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this clean revert! I've reviewed the changes and confirmed that all GPT-5 related features have been properly removed across the codebase.

The revert successfully removes:

  • GPT-5 model definitions (gpt-5, gpt-5-mini, gpt-5-nano)
  • The "minimal" reasoning effort option
  • Verbosity control features
  • GPT-5 metadata persistence
  • Responses API implementation
  • Related test coverage
  • UI components and i18n entries

One minor suggestion: Could you provide more context in the PR description about which specific aspects will be split into separate PRs? This would help reviewers understand the planned breakdown.

@daniel-lxs daniel-lxs closed this Aug 11, 2025
@github-project-automation github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap Aug 11, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 11, 2025
@daniel-lxs daniel-lxs deleted the revert-6864-openai-provider-updates branch August 11, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants