Skip to content

fix: remove 500-message limit to prevent scrollbar jumping in long conversations #7053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roomote wants to merge 2 commits into from
Closed

fix: remove 500-message limit to prevent scrollbar jumping in long conversations #7053

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aec4cf
fix: remove 500-message limit to prevent scrollbar jumping in long co…
roomote Aug 13, 2025
409024c
chore: remove comment
daniel-lxs Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions webview-ui/src/components/chat/ChatView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,11 +897,7 @@ const ChatViewComponent: React.ForwardRefRenderFunction<ChatViewRef, ChatViewPro
useMount(() => textAreaRef.current?.focus())

const visibleMessages = useMemo(() => {
const currentMessageCount = modifiedMessages.length
const startIndex = Math.max(0, currentMessageCount - 500)
const recentMessages = modifiedMessages.slice(startIndex)

const newVisibleMessages = recentMessages.filter((message: ClineMessage) => {
const newVisibleMessages = modifiedMessages.filter((message: ClineMessage) => {
Copy link
Contributor Author

@roomote roomote bot Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're removing the message limit entirely, it might be worth adding tests that verify:

  • Messages are correctly filtered without slicing
  • Virtuoso receives all messages for virtualization
  • Scroll position is maintained when new messages arrive

I noticed there aren't specific tests for ChatView's message handling - this would be a good opportunity to add them.

if (everVisibleMessagesTsRef.current.has(message.ts)) {
const alwaysHiddenOnceProcessedAsk: ClineAsk[] = [
"api_req_failed",
Expand Down
Loading