-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: update terminal settings documentation link #8997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Updated shell integration disabled doc link to point to correct section - Updated all locale translation files for terminal settings
|
Review completed. No issues found. The changes correctly update the documentation link and improve UI text consistency across all locale files. Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR standardizes terminal-related descriptions across all locales by consolidating redundant information about "VS Code terminal only" and IDE restart requirements. The changes include:
- Moved terminal applicability information from individual setting descriptions to the parent "Advanced" section description
- Removed redundant mentions of "VS Code terminal only" and "May require IDE restart" from individual settings (commandDelay, zshOhMy)
- Updated documentation link for shell integration disabled setting
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| webview-ui/src/i18n/locales/en/settings.json | English locale: Added terminal scope and restart requirement to advanced description, removed redundancy from commandDelay and zshOhMy descriptions |
| webview-ui/src/i18n/locales/zh-TW/settings.json | Traditional Chinese locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/zh-CN/settings.json | Simplified Chinese locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/vi/settings.json | Vietnamese locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/tr/settings.json | Turkish locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/ru/settings.json | Russian locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/pt-BR/settings.json | Brazilian Portuguese locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/pl/settings.json | Polish locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/nl/settings.json | Dutch locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/ko/settings.json | Korean locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/ja/settings.json | Japanese locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/it/settings.json | Italian locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/id/settings.json | Indonesian locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/hi/settings.json | Hindi locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/fr/settings.json | French locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/es/settings.json | Spanish locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/de/settings.json | German locale: Applied same consolidation pattern |
| webview-ui/src/i18n/locales/ca/settings.json | Catalan locale: Applied same consolidation pattern |
| webview-ui/src/components/settings/TerminalSettings.tsx | Updated documentation link anchor for shell integration disabled setting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Updated the documentation link for the 'Disable Terminal Shell Integration' setting to point to the correct section of the documentation.
Changes
Type of Change
Testing
Important
Update terminal settings documentation link in
TerminalSettings.tsxand ensure consistency across locale translation files.TerminalSettings.tsxto 'use-inline-terminal-recommended'.This description was created by
for fe6b477. You can customize this summary. It will automatically update as commits are pushed.