Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Nov 3, 2025

Description

Updated the documentation link for the 'Disable Terminal Shell Integration' setting to point to the correct section of the documentation.

Changes

  • Updated shell integration disabled doc link in TerminalSettings.tsx to point to 'use-inline-terminal-recommended' section
  • Updated all locale translation files for terminal settings consistency

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing

  • Verified all linting checks pass
  • Verified all type checks pass

Important

Update terminal settings documentation link in TerminalSettings.tsx and ensure consistency across locale translation files.

  • Behavior:
    • Update documentation link in TerminalSettings.tsx to 'use-inline-terminal-recommended'.
    • Ensure consistency in terminal settings descriptions across all locale translation files.
  • Testing:
    • Verified all linting and type checks pass.

This description was created by Ellipsis for fe6b477. You can customize this summary. It will automatically update as commits are pushed.

- Updated shell integration disabled doc link to point to correct section
- Updated all locale translation files for terminal settings
Copilot AI review requested due to automatic review settings November 3, 2025 17:36
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Nov 3, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 3, 2025

See this task on Roo Code Cloud

Review completed. No issues found. The changes correctly update the documentation link and improve UI text consistency across all locale files.

Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes terminal-related descriptions across all locales by consolidating redundant information about "VS Code terminal only" and IDE restart requirements. The changes include:

  • Moved terminal applicability information from individual setting descriptions to the parent "Advanced" section description
  • Removed redundant mentions of "VS Code terminal only" and "May require IDE restart" from individual settings (commandDelay, zshOhMy)
  • Updated documentation link for shell integration disabled setting

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
webview-ui/src/i18n/locales/en/settings.json English locale: Added terminal scope and restart requirement to advanced description, removed redundancy from commandDelay and zshOhMy descriptions
webview-ui/src/i18n/locales/zh-TW/settings.json Traditional Chinese locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/zh-CN/settings.json Simplified Chinese locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/vi/settings.json Vietnamese locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/tr/settings.json Turkish locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/ru/settings.json Russian locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/pt-BR/settings.json Brazilian Portuguese locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/pl/settings.json Polish locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/nl/settings.json Dutch locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/ko/settings.json Korean locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/ja/settings.json Japanese locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/it/settings.json Italian locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/id/settings.json Indonesian locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/hi/settings.json Hindi locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/fr/settings.json French locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/es/settings.json Spanish locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/de/settings.json German locale: Applied same consolidation pattern
webview-ui/src/i18n/locales/ca/settings.json Catalan locale: Applied same consolidation pattern
webview-ui/src/components/settings/TerminalSettings.tsx Updated documentation link anchor for shell integration disabled setting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 3, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 3, 2025
@mrubens mrubens merged commit 5c738de into main Nov 3, 2025
29 checks passed
@mrubens mrubens deleted the fix/terminal-settings-doc-link branch November 3, 2025 18:17
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Nov 3, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants