-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: simplify Google Analytics to standard implementation #9044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Remove Consent Mode v2 implementation - Remove URL passthrough and cookieless tracking features - Switch to Google's standard out-of-the-box gtag.js pattern - Maintain consent-based loading (scripts only load after user consent) Rationale: The standard OoTB implementation is more stable and complies with consent requirements. The cookieless tracking wasn't working properly, and the effort to get it working isn't worth the added complexity.
|
Review completed. All previously identified issues have been resolved.
Mention @roomote in a comment to trigger your PR Fixer agent and make changes to this pull request. |
|
🚀 Preview deployed! Your changes have been deployed to Vercel: Preview URL: https://roo-code-website-i59km9c5l-roo-code.vercel.app This preview will be updated automatically when you push new commits to this PR. |
apps/web-roo-code/src/components/providers/google-analytics-provider.tsx
Outdated
Show resolved
Hide resolved
apps/web-roo-code/src/components/providers/google-analytics-provider.tsx
Outdated
Show resolved
Hide resolved
|
@roomote address all feedback in this PR. |
|
Fixed the reported issues. All local checks passed. |
|
LGTM |
Summary
This PR simplifies the Google Analytics implementation by removing Consent Mode v2 and cookieless tracking features in favor of Google's standard out-of-the-box gtag.js pattern.
Changes
Rationale
The standard out-of-the-box implementation is more stable and complies with consent requirements. The cookieless tracking wasn't working properly, and the effort to get it working isn't worth the added complexity.
Benefits:
Technical Details
The new implementation:
Important
Simplifies Google Analytics by removing complex features and adopting standard
gtag.jspattern ingoogle-analytics-provider.tsx.google-analytics-provider.tsx.gtag.jsloading pattern, loading scripts only after user consent.google-analytics-provider.tsx.dataLayerandgtagingoogle-analytics-provider.tsx.This description was created by
for ab22b2d. You can customize this summary. It will automatically update as commits are pushed.