Skip to content

fix: rebuild API handler on profile switch with same provider/model #9209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roomote wants to merge 1 commit into from
Closed

fix: rebuild API handler on profile switch with same provider/model #9209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/core/webview/ClineProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,6 +1280,7 @@ export class ClineProvider
const profile = listApiConfig.find(({ id }) => id === savedConfigId)

if (profile?.name) {
// This is a mode switch, which should apply all settings
await this.activateProviderProfile({ name: profile.name })
}
} else {
Expand All @@ -1305,8 +1306,9 @@ export class ClineProvider
* Also synchronizes the task.apiConfiguration so subsequent comparisons and logic
* (protocol selection, reasoning display, model metadata) use the latest profile.
* @param providerSettings The new provider settings to apply
* @param forceRebuild If true, always rebuild the API handler regardless of provider/model changes
*/
private updateTaskApiHandlerIfNeeded(providerSettings: ProviderSettings): void {
private updateTaskApiHandlerIfNeeded(providerSettings: ProviderSettings, forceRebuild: boolean = false): void {
const task = this.getCurrentTask()
if (!task) return

Expand All @@ -1317,7 +1319,8 @@ export class ClineProvider
const newProvider = providerSettings.apiProvider
const newModelId = getModelId(providerSettings)

if (prevProvider !== newProvider || prevModelId !== newModelId) {
// Rebuild if forced (explicit profile switch) or if provider/model changed
if (forceRebuild || prevProvider !== newProvider || prevModelId !== newModelId) {
task.api = buildApiHandler(providerSettings)
}

Expand Down Expand Up @@ -1373,6 +1376,7 @@ export class ClineProvider

// Change the provider for the current task.
// TODO: We should rename `buildApiHandler` for clarity (e.g. `getProviderClient`).
// Don't force rebuild here since this is part of upsert, not explicit switch
this.updateTaskApiHandlerIfNeeded(providerSettings)
} else {
await this.updateGlobalState("listApiConfigMeta", await this.providerSettingsManager.listConfig())
Expand Down Expand Up @@ -1430,7 +1434,8 @@ export class ClineProvider
}

// Change the provider for the current task.
this.updateTaskApiHandlerIfNeeded(providerSettings)
// Force rebuild since this is an explicit profile switch by the user
this.updateTaskApiHandlerIfNeeded(providerSettings, true)

await this.postStateToWebview()

Expand Down
Loading
Loading