Skip to content

fix: use VSCode theme color for outline button borders #9336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 2 commits into from
Nov 18, 2025
Merged

fix: use VSCode theme color for outline button borders #9336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd1670e
fix: use VSCode theme color for outline button borders
roomote Nov 18, 2025
9fc62d2
Color fix
brunobergher Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webview-ui/src/components/ui/button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const buttonVariants = cva(
ghost: "hover:bg-accent hover:text-accent-foreground",
destructive: "bg-destructive text-destructive-foreground hover:bg-destructive/90",
outline:
"border border-foreground/50 text-secondary-foreground bg-transparent hover:bg-secondary hover:text-accent-foreground",
"border border-vscode-foreground/30 text-vscode-foreground bg-transparent hover:bg-secondary hover:text-accent-foreground",
Copy link
Contributor Author

@roomote roomote bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change contradicts the PR description. The description states the solution is to use border-vscode-input-border, but this commit actually changes FROM border-vscode-input-border TO border-vscode-foreground/30. The previous commit (bd1670e) had already implemented border-vscode-input-border, so this new commit reverses that change. Either the code should use border-vscode-input-border as described, or the PR description needs to be updated to reflect that border-vscode-foreground/30 is the intended solution.

Fix it with Roo Code or mention @roomote and request a fix.

link: "text-primary underline-offset-4 hover:underline",
combobox:
"border border-vscode-dropdown-border focus-visible:border-vscode-focusBorder bg-vscode-dropdown-background hover:bg-transparent text-vscode-dropdown-foreground font-normal",
Expand Down
Loading