fix: remove reasoning toggles for GLM-4.5 and GLM-4.6 on z.ai provider #9752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the reasoning toggle UI for GLM-4.5 and GLM-4.6 models on the z.ai provider, as confirmed by the z.ai team that these models were trained without think/reasoning data for coding agents.
Changes Made
supportsReasoningBinary: truefrom GLM-4.5 (both international and mainland variants)supportsReasoningBinary: truefrom GLM-4.6 (both international and mainland variants)zai.spec.tssince no current z.ai models support reasoningContext
According to the z.ai team: "For scenarios in coding agents, GLM-4.5 and 4.6 were trained with non-think data. We might add think in the next-generation, but it will be a new model. Think in coding agents will be available in GLM-4.6 Air."
This means the reasoning toggle should not be shown for these models, as they do not support extended thinking/reasoning capabilities in coding agent scenarios.
Testing
View task on Roo Code Cloud
Important
Remove reasoning toggle for GLM-4.5 and GLM-4.6 models on z.ai provider due to lack of reasoning data support.
supportsReasoningBinary: truefrom GLM-4.5 and GLM-4.6 models inzai.ts.zai.spec.tsas no z.ai models support reasoning.zai.spec.tspass after changes.This description was created by
for 16c3e10. You can customize this summary. It will automatically update as commits are pushed.