Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Dec 2, 2025

Removes the reasoning toggle UI for GLM-4.5 and GLM-4.6 models on the z.ai provider, as confirmed by the z.ai team that these models were trained without think/reasoning data for coding agents.

Changes Made

  • Removed supportsReasoningBinary: true from GLM-4.5 (both international and mainland variants)
  • Removed supportsReasoningBinary: true from GLM-4.6 (both international and mainland variants)
  • Removed all reasoning-related tests from zai.spec.ts since no current z.ai models support reasoning

Context

According to the z.ai team: "For scenarios in coding agents, GLM-4.5 and 4.6 were trained with non-think data. We might add think in the next-generation, but it will be a new model. Think in coding agents will be available in GLM-4.6 Air."

This means the reasoning toggle should not be shown for these models, as they do not support extended thinking/reasoning capabilities in coding agent scenarios.

Testing

  • ✅ All zai.spec.ts tests pass (19 tests)
  • ✅ Linting passes
  • ✅ Type checking passes

View task on Roo Code Cloud


Important

Remove reasoning toggle for GLM-4.5 and GLM-4.6 models on z.ai provider due to lack of reasoning data support.

  • Behavior:
    • Removed supportsReasoningBinary: true from GLM-4.5 and GLM-4.6 models in zai.ts.
    • Removed reasoning-related tests from zai.spec.ts as no z.ai models support reasoning.
  • Context:
    • GLM-4.5 and 4.6 models were trained without reasoning data for coding agents, confirmed by z.ai team.
  • Testing:
    • All tests in zai.spec.ts pass after changes.

This description was created by Ellipsis for 16c3e10. You can customize this summary. It will automatically update as commits are pushed.

@roomote
Copy link
Contributor Author

roomote bot commented Dec 2, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The changes correctly remove supportsReasoningBinary from GLM-4.5 and GLM-4.6 models (both international and mainland variants) and clean up the corresponding tests. This aligns with the z.ai team's guidance that these models were trained without think/reasoning data for coding agents.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 2, 2025
@hannesrudolph hannesrudolph marked this pull request as ready for review December 2, 2025 18:41
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 2, 2025
@hannesrudolph hannesrudolph moved this from Triage to PR [Needs Review] in Roo Code Roadmap Dec 2, 2025
@dosubot dosubot bot added the bug Something isn't working label Dec 2, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Dec 2, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The changes correctly remove supportsReasoningBinary from GLM-4.5 and GLM-4.6 models (both international and mainland variants) and clean up the corresponding tests. This aligns with the z.ai team's guidance that these models were trained without think/reasoning data for coding agents.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@mrubens mrubens merged commit 9a1d7a6 into main Dec 2, 2025
28 of 31 checks passed
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Dec 2, 2025
@mrubens mrubens deleted the fix/remove-zai-reasoning-toggles branch December 2, 2025 19:20
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Dec 2, 2025
@roomote roomote bot mentioned this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer PR - Needs Review size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants