refactor: decouple tools from system prompt

[daniel-lxs]

Summary

The system prompt sections no longer change based on which tools are available. All tool-specific instructions are now in the tool descriptions themselves. This simplifies the codebase and makes tool behavior self-contained.

Changes

Tool Descriptions Updated (XML & Native)

• codebase_search: Added CRITICAL usage instructions about using it first for code exploration
• write_to_file: Added guidance about preferring other editing tools, complete file content requirements, project creation best practices
• search_files: Added regex pattern crafting guidance, context analysis tips
• browser_action: Added web development usage guidance, non-development task handling

System Prompt Sections Simplified

• rules.ts: Removed getEditingInstructions(), all editing tool conditionals, browser_action conditionals. Function signature simplified from 8 params to 3.
• capabilities.ts: Removed all tool availability conditionals, diffStrategy, mode-specific logic. Function signature simplified from 9 params to 2.
• tool-use-guidelines.ts: Removed codeIndexManager parameter and conditional guidelines. Function signature simplified.
• objective.ts: Removed all parameters and conditional codebase_search instruction. Function now takes no parameters.
• system.ts: Updated calls to match new simplified signatures

Tests Updated

• Deleted mode-aware-sections.spec.ts (was testing removed behavior)
• Updated sections.spec.ts for new signatures
• Updated snapshot files

Benefits

• Tool instructions are self-contained in their descriptions
• System prompt is simpler and more predictable
• Reduced coupling between prompt sections and tool availability
• Easier to add/modify tool instructions without affecting system prompt

Testing

All 4456 tests pass (339 test files)

---

Important

Refactor system prompt to decouple tool-specific instructions, simplifying the codebase and enhancing predictability.

• Behavior:
  • System prompt no longer changes based on available tools; tool-specific instructions are now in tool descriptions.
  • codebase_search must be used first for unexplored code areas.
• Code Changes:
  • Removed tool availability conditionals from rules.ts, capabilities.ts, tool-use-guidelines.ts, and objective.ts.
  • Simplified function signatures in rules.ts, capabilities.ts, tool-use-guidelines.ts, and objective.ts.
  • Updated sections.spec.ts and objective.spec.ts to reflect changes.
• Testing:
  • Deleted mode-aware-sections.spec.ts as it tested removed behavior.
  • Updated sections.spec.ts for new function signatures.
  • All tests pass (4456 tests across 339 files).

^{This description was created by for 9c3781e. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Rooviewer   See task on Roo Cloud

Re-reviewed the latest commits. The previously flagged issue has been resolved. No new issues found.

• Remove unused diffStrategy parameter from getRulesSection() in rules.ts

Previous reviews

• 3f5c534: Review #1
• 66d632a: Review #2
• 66d632a: Review #3

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

[hannesrudolph]

Overall this is a well-structured refactor that achieves its stated goal of decoupling tool-specific instructions from system prompt sections. The changes reduce coupling and make the codebase simpler and more maintainable. Found one cleanup issue noted below.

Note: The PR has merge conflicts that need to be resolved before merging.

[roomote]

Rooviewer   See task on Roo Cloud

Review completed. Found 1 minor cleanup issue.

This refactoring successfully decouples tool-specific instructions from the system prompt by moving them into the tool descriptions themselves. The changes simplify the codebase while maintaining the same functionality.

• Remove unused diffStrategy parameter from getRulesSection() in rules.ts

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}