Add MSAL#3
Merged
Merged
Conversation
johnyenter-briars
requested changes
Mar 9, 2023
| private readonly string ClientId = ""; | ||
| private HttpClient Client { get; set; } = new HttpClient(); | ||
| public AuthService(string clientId) | ||
| private const string TokenCacheFileName = "CalendulaTokenCache"; |
Collaborator
There was a problem hiding this comment.
@plohm12 - the formatting looks a bit off on my screen for this file - can you confirm the formatting looks ok on VS ? Or maybe run it through the formatter? Other than that looks sick
Collaborator
Author
There was a problem hiding this comment.
yea i see what you mean... i tested the MSAL code in linqpad and copied it into this class file, so i'll have to format it.
johnyenter-briars
approved these changes
Mar 9, 2023
Collaborator
johnyenter-briars
left a comment
johnyenter-briars
left a comment
There was a problem hiding this comment.
@plohm12 looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.