feat: add native titlebar option#300
Conversation
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Thank you for this contribution. We're deep in the throws of getting 0.15.0 out the door and then implementing a short code freeze to complete some refactoring, but then will swing over to playing with this. You're not the first to bring up the desire but you're the first to submit a PR! 🙏 |
|
@mastern2k3 finally getting around to this. can you rebase and if convenient drop a screenshot? |
|
@greptile review |
|
✅ Actions performedReview triggered.
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryAdded a toggle in Settings > General to switch between Maestro's custom title bar and the OS native title bar, requiring a restart to take effect. This is useful for tiling window manager users where the custom title bar wastes vertical space. Key changes:
Note: The Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User toggles setting in SettingsModal] --> B[useSettings hook persists to electron-store]
B --> C[Setting requires restart]
C --> D[App restarts]
D --> E[main/index.ts reads early settings via getEarlySettings]
E --> F[useNativeTitleBar passed to window manager]
F --> G{useNativeTitleBar?}
G -->|false| H[Apply titleBarStyle: hiddenInset on macOS]
G -->|true| I[Use OS native title bar]
H --> J[Renderer shows custom title bar with pt-10]
I --> K[Renderer hides custom title bar with pt-0]
J --> L[Custom draggable title bar visible]
K --> M[OS native title bar controls]
Last reviewed commit: b18ff3d |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| minHeight: 600, | ||
| backgroundColor: '#0b0b0d', | ||
| titleBarStyle: 'hiddenInset', | ||
| ...(useNativeTitleBar ? {} : { titleBarStyle: 'hiddenInset' as const }), |
There was a problem hiding this comment.
titleBarStyle: 'hiddenInset' is macOS-specific and ignored on Windows/Linux where native title bar is always shown regardless of this setting. Consider documenting this platform-specific behavior in the settings UI description.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Add native title bar and auto-hide menu bar toggles under Settings > Display > Window Chrome (implements PR #300 and #293 as proper settings). Both are read as early settings before window creation and conditionally applied to BrowserWindow options. Extract buildUnifiedTabs and ensureInUnifiedTabOrder into tabHelpers as shared utilities, replacing duplicate implementations in useTabHandlers and tabStore. Fix orphaned tab repair in reopenUnifiedClosedTab and include file tabs in session restoration fallback for unifiedTabOrder.
|
Closing this PR but the code is making it in! Credit will still apply. I simply merged it into a "polish" branch first so that I could unify the experience: 
|
|
hey @pedramamini , sorry for the late response, glad to hear it made it in. Is there anything else you need me to do? |
2 participants
Adds a toggle in Settings > General to switch from Maestro's custom title bar to the OS native title bar. Useful for tiling window manager users where the custom title bar is wasted vertical space. Requires restart to take effect.