Skip to content

docs: enhance CLAUDE.md with work items and contribution workflow#5

Closed
openasocket wants to merge 1 commit intoRunMaestro:mainfrom
openasocket:docs/claude-md-enhancement
Closed

docs: enhance CLAUDE.md with work items and contribution workflow#5
openasocket wants to merge 1 commit intoRunMaestro:mainfrom
openasocket:docs/claude-md-enhancement

Conversation

@openasocket
Copy link
Contributor

  • Add Current Work Items section with prioritized tasks and branch names
    • High: User error notifications (App.tsx:1805, useSessionManager.ts:254)
    • High: Phase 6 remote access stubs (web-server.ts:62-104)
    • Medium: Tunnel provider integration, error feedback improvements
    • Low: LLM Settings panel (disabled feature)
  • Add Contributing Workflow section
    • Fork and Setup instructions (first time contributors)
    • Branch naming conventions (feat/, fix/, docs/, refactor/)
    • PR creation guide with gh CLI and web options
    • Keeping fork updated/synced with upstream
  • Add Error Handling Patterns with code examples
  • Add Related Documentation section

🤖 Generated with Claude Code

Co-Authored-By: openasocket openasocket@users.noreply.github.com
Co-Authored-By: Claude noreply@anthropic.com

- Add Current Work Items section with prioritized tasks and branch names
  - High: User error notifications (App.tsx:1805, useSessionManager.ts:254)
  - High: Phase 6 remote access stubs (web-server.ts:62-104)
  - Medium: Tunnel provider integration, error feedback improvements
  - Low: LLM Settings panel (disabled feature)
- Add Contributing Workflow section
  - Fork and Setup instructions (first time contributors)
  - Branch naming conventions (feat/, fix/, docs/, refactor/)
  - PR creation guide with gh CLI and web options
  - Keeping fork updated/synced with upstream
- Add Error Handling Patterns with code examples
- Add Related Documentation section

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: openasocket <openasocket@users.noreply.github.com>
Co-Authored-By: Claude <noreply@anthropic.com>
@pedramamini
Copy link
Collaborator

I want to keep developer information in contributing.md and any planning should not go into Claude.md because I want Claude.md to be super small and not eat up the context especially since the runners will leverage Cloud.MD in every single iteration.

@claude claude bot mentioned this pull request Nov 29, 2025
@pedramamini pedramamini closed this Dec 1, 2025
This was referenced Dec 10, 2025
@claude claude bot mentioned this pull request Dec 19, 2025
reachraza added a commit that referenced this pull request Feb 6, 2026
Address PR review feedback:

- Issue #1: Add early returns in openModal, closeModal, and closeAll
  to skip Map recreation when state hasn't changed. Prevents
  unnecessary selector re-evaluations across all subscribers.

- Issue #2: Add JSDoc to useModalActions() explaining that the ~40
  selector subscriptions are intentionally transitional — identical
  to old Context behavior. Components should migrate to direct
  useModalStore(selectModalOpen(...)) calls for granular subscriptions.

- Issue #5: Add 14 new tests covering no-op guard behavior (7 tests
  including render count verification), getModalActions() API surface
  and cross-call store sharing (3 tests), and useModalActions()
  reactive state and compatibility (4 tests).

Issues #3 (memory leak) and #4 (type overloads) are not actionable:
47 fixed modal IDs is bounded, and ModalDataFor<T> already resolves
to undefined for unmapped modals.
@claude claude bot mentioned this pull request Feb 7, 2026
claudepalmeragent pushed a commit to claudepalmeragent/Maestro that referenced this pull request Feb 9, 2026
Adds investigation and planning documents for:

1. PRICING-BUGFIXES-PHASE2.md - Summary of 5 issues found during testing:
   - Issue RunMaestro#1: Agent Settings Detection - WORKING CORRECTLY
   - Issue RunMaestro#2: Folder Toggle Shows Blank - Minor bug, fix ready
   - Issue RunMaestro#3: Folder Detection Shows API - Critical bug, fix ready
   - Issue RunMaestro#4: Analysis of RunMaestro#1 vs RunMaestro#3
   - Issue RunMaestro#5: Dashboard costs - Requires separate plan

2. PRICING-DASHBOARD-COST-FIX.md - Comprehensive plan for Issue RunMaestro#5:
   - Root cause: Costs stored at API rates, billing mode never applied
   - Solution: Recalculate at storage time with proper billing mode
   - 6-phase implementation plan with database schema changes
   - Risk assessment and mitigation strategies
   - Timeline estimate: 12-18 hours

Auto Run fix documents created in /app/__AUTORUN/:
- PRICING-FIX-02-FOLDER-TOGGLE.md
- PRICING-FIX-03-FOLDER-DETECTION.md

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
claudepalmeragent pushed a commit to claudepalmeragent/Maestro that referenced this pull request Feb 9, 2026
Investigation and implementation plan for detecting when Claude Code
is configured to use local Ollama servers or other non-Claude model
providers, and marking those queries as FREE ($0 cost).

Key findings:
- Model name in Claude Code output reveals actual provider
- `modelUsage` keys like "ollama/llama2" indicate local/free models
- `isClaudeModelId()` already exists - just need to invert for detection

Proposed solution:
- Add 'free' to ClaudeBillingMode enum
- Create model-provider-detector.ts with pattern matching
- Auto-detect provider from model name in output
- Set cost to $0 for non-Claude providers (Ollama, local models)
- Add provider badge to UI (Claude/Ollama/Free)

Dependencies:
- Should be implemented AFTER Issue RunMaestro#5 (Dashboard Cost Fix)
- Shares database schema and pipeline changes with RunMaestro#5

Timeline: 12-15 hours (after Issue RunMaestro#5)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments