Skip to content
This repository was archived by the owner on Jun 7, 2023. It is now read-only.

Conversation

@ericsonga
Copy link
Contributor

I added a notimer option on the timed exams to allow for no timer to be displayed. Jeff Rick added paired distractors that are displayed either above or below the correct code to make it easy for the user to pick between the correct code and the distractor.

…ow paired distractors in Parsons problems

I added a notimer option on the timed exams and Jeff Rick added new
functionality to the Parsons problems (paired distractors that stay
next to the correct code when displayed).
@bnmnetp
Copy link
Member

bnmnetp commented Apr 11, 2016

Barb,

Is this ready for review or is work ongoing?

One question: with parsons.js, I'm always a bit worried about us changing the parsons.js file. This makes it much harder to get a new version of parsons from Ville with his changes and new features. If these are bug fixes to parsons we should make a PR back to the original to stay in sync. If these are custom for us, then is there a way to factor them out of the parsons.js source?

@ericsonga
Copy link
Contributor Author

Yes, this is ready for review. I am not worried about staying with Ville's version. I don't think they are working much on it and we are basically rewriting it to add the functionality I want.

@bnmnetp bnmnetp merged commit acef6bd into RunestoneInteractive:master May 1, 2016
@bnmnetp
Copy link
Member

bnmnetp commented May 1, 2016

@ericsonga When I accepted this PR and rebuilt my tests, I am now seeing that we are losing the indentation the multiline parson's blocks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants