Added functionality to reset timed exams. #399

conzty01 · 2017-06-22T22:27:59Z

This is still a 'work in progress'. What needs to be added is a way for the javascript to check with the server and see if the exam has been taken before it will activate the reset button. It also needs to record that the exam has been reset.

conzty01 · 2017-06-23T22:00:09Z

This is now functional.

Fetched Upstream Updates

Fetch 7/5/2017

Merge Upstream 7/6/2017

bnmnetp

I temporarily fixed the problem with True in my local branch. And then attempted to reset the exam. However when I press the reset button it looks like the exam is submitted because it now shows me all the answers and feedback. In addition I have two rows written to the database at the same instant. One shows the reset and the other just shows as though I had submitted. I'm using Safari, I'm going to try this same exercise in Chrome just to verify.

bnmnetp · 2017-07-07T18:49:23Z

runestone/assess/js/timed.js

+        if (window.confirm("Only reset the exam if you encountered problems completing it. The Instructor will be notified of the reset.")) {
+            eventInfo = {"event":"timedExam","act":"reset","div_id":this.divid,
+                         "course":eBookConfig.course,"correct":this.score,"incorrect":this.incorrect,
+                         "skipped":this.skipped,"time":this.timeTaken,"reset":True}


the "reset":True should be "reset":true Capital True is Python.

bnmnetp

I get the same behavior in chrome.

I cleared the database and local storage.
I answered a couple of questions and then closed the tab.
I opened the tab and went back to the quiz. The reset button was available so I tried to reset the quiz.
after my reset it showed me the feedback for everything.

conzty01 · 2017-07-07T20:22:02Z

Did the page refresh after you hit the reset button? And, if so, were you able to retake the quiz and submit answers? @bnmnetp

bnmnetp · 2017-07-07T20:59:43Z

The page did refresh, but I was not able to answer any of the unanswered questions.

conzty01 · 2017-07-07T21:55:06Z

Fixes on the server-side

bnmnetp · 2017-07-10T19:45:55Z

@conzty01

I'm still trying to get this to work the way I think it should. Maybe we didn't have a good understanding on this one.

I start the exam and answer a couple of questions.
I force close the page. -- nothing in the database yet
I go back to the page. Now I can see the questions. None of them have the feedback showing, but I cannot answer any questions. The timer is not running. The Reset button is active now. -- this seems like a bad state. Now I appear to have as much time as I want to look at and think about these questions.
I click reset and OK
The page refreshes and all of the feedback is showing for all of the questions. I still can't answer any.

What I would expect to happen

I start the exam and answer some questions.
I force close the page.
I go back to the page. I can see the feedback for the questions I already answered before the force close, but I cannot see feedback for unanswered questions. Reset is available.
I click on reset. -- a database entry is made indicating the reset, and the questions I had already answered.
Feedback is still there for the questions I already answered. But now I can answer the questions that I had not answered before.
I submit my exam -- another database row is added with my final information.

conzty01 · 2017-07-10T20:02:30Z

Our understandings of what you were looking for were a bit off, but I have not been able to replicate the issue you are having with not being able to answer the questions after the reset. I am still working on getting my VM back up and running as I am having issues installing, but I will start to work on implementing the behavior you are looking for when I can.

bnmnetp · 2017-07-10T20:07:39Z

OK, please describe for me your understanding of what I should expect. Once we have compared notes we can decide on the best course.

conzty01 · 2017-07-10T20:23:25Z

Start the exam and answer some questions.
Force close the page.
Reload page. See feedback for the questions previously answered before the force close, but not for unanswered questions. Reset is enabled.
Click on reset. Database is notified of reset and previous answers.
Feedback is still there for the questions already answered. But now the user can answer the questions that that were not answered before.
Submit the exam. Feedback is displayed for entire exam and database is notified of completed exam.

conzty01 · 2017-07-10T20:27:19Z

Might I suggest, that feedback would be kept hidden until the entire exam is completed. This would eliminate the possibility of being able to read the question without the timer running and the lack of the green and red highlighting would be an indication to a student browsing by or double checking the submission that the exam was not finished properly.

Such a design might behave like:

Start exam and answer some, but not all, questions
Force navigation away from the page
Reload page and see that exam appear similar to how it was before starting but with an updated timer to reflect how much time they took previously.
4a. Hit 'Reset' to reset entire exam
5a. Page reloads with a fresh copy of the exam and record of reset is sent to the database.

4b. Hit start exam again and resume the exam as before but without the ability to edit previously answered questions.
5b. On completion, the exam displays all feedback.

bnmnetp · 2017-07-10T21:20:56Z

@conzty01, I like your second option a lot.

Merge Upstream 7/11 9:23AM

conzty01 · 2017-07-11T22:11:22Z

So, my newly installed VM doesn't have the same functionality with the reset feature that it did before the crash, so I believe we are in the same boat now. Because of the lack of functionality and the new approach that you would like from my last comment, I have gone through the timed.js script, excluding any changes I made for the reset, to try to figure out where/when might be the best place to check the localStorage and server for submitted exams. The "flow" chart that I found is below.

conzty01 · 2017-07-11T22:11:28Z

conzty01 · 2017-07-11T22:17:48Z

The bulk of the loading of the timed exam is in done in the tookTimedExam( ) function so I figure that that would be the most appropriate place to check for previous answers. However, I am stuck on how to proceed with checking-- i.e. which place do I check for answers first and when in the order should it occur. My initial idea is to check right at the beginning of tookTimedExam( ) but from there I am unsure. Thoughts, @bnmnetp ? The flowchart begins from the "Timedexam init" box in the top left corner.

bnmnetp · 2017-07-11T22:35:01Z

So, if there is not a full timed_exam entry in localStorage but there are individual entries for one or more of the timed elements that is a really strong indication that the exam was interrupted or force quit somehow right?

I think you will already want to invent a local storage way to keep track of the time. So maybe you could also use local storage to keep track of whether the exam was submitted or not??

bnmnetp · 2017-07-11T22:46:05Z

@conzty01 Not sure my response made sense, and I'm not sure I understand your flowchart. Maybe we should do a hangout tomorrow morning to really work this out.

Fetch Upstream 7/12/17 8:39AM

conzty01 · 2017-07-12T15:06:41Z

Re-order timed.js to eliminate extraneous/outdated code.
Keep track of time taken on the exam in localStorage.
If Database has no results for exam, check localStorage for answers.
- If the difference between the timestamp and current time is greater than the length allotted for the exam, do not allow students to continue the exam.
- If the difference listed previously is less than the allotted time, allow the students to continue the exam without changing previous answers.
Display feedback at the end of an exam only if the exam is either finished, or there is a database entry.
Allow exam to be reset if the Database has no record of an exam and localStorage says that all questions were skipped.

conzty01 · 2017-07-14T18:35:35Z

Server Updates

conzty01 · 2017-07-14T18:49:36Z

I've updated the reset function if you'd like to take a look, @bnmnetp , but I am still working on being able to resume an incomplete exam.

Fetch Upstream 07/17/17 8:36AM

Alert now occurs when the server determines an exam is not a candidate for resetting.

Pull 07/18/17 8:43AM

Merge Upstream 07/18/17 8:49AM

Fetch upstream 07/19/17 1:05PM

bnmnetp · 2017-07-20T15:14:07Z

It seems to me that this is a good point to stop with this one. I can see some benefit to being able to restore answers prior to some kind of catastrophic end to the exam, but the additional complexity it would add to all of the components and the already fragile nature of the timed_exams make me think that a simple reset capability is all that is needed.

Fetch Upstream 07/21/17 10:30AM

bnmnetp

It seems like almost all of the changes I made to runestone base are undone by this PR. Can you identify exactly what you intended to change so I can make sure all of mine are restored?

bnmnetp · 2017-07-21T16:09:41Z

runestone/common/js/runestonebase.js

@@ -1,35 +1,7 @@
-/**


This should not have been deleted. Any idea why it was?

bnmnetp · 2017-07-21T16:09:53Z

runestone/common/js/runestonebase.js


 }

-RunestoneBase.prototype.init = function(opts) {


this should not have been deleted either

bnmnetp · 2017-07-21T16:10:14Z

runestone/common/js/runestonebase.js


 RunestoneBase.prototype.checkServer = function (eventInfo) {
    // Check if the server has stored answer
-    if (this.useRunestoneServices || this.graderactive) {


bnmnetp · 2017-07-21T16:10:21Z

runestone/common/js/runestonebase.js

        data.div_id = this.divid;
        data.course = eBookConfig.course;
        data.event = eventInfo;
-        if (this.sid) {


bnmnetp · 2017-07-21T18:38:51Z

runestone/assess/js/timed.js

    for (var i = 0; i < this.newChildren.length; i++) {
        var tmpChild = this.newChildren[i];
        opts = {'orig':tmpChild, 'useRunestoneServices':eBookConfig.useRunestoneServices}
-        if ($(tmpChild).children("[data-component]")) {


these should not have disappeared either

Fetch upstream 3:57PM 7/24/17

bnmnetp

With the exception of a . instead of a , on line 899 causing getAssessResults to fail every time, this seems to work fine now. I fixed the problem, and will include it in my merge.

Added functionality to reset timed exams.

5b0e3f9

bnmnetp added the in progress label Jun 22, 2017

Added Reset functionality to timed_exam

4e68c69

Merge branch 'master' into master

110a28c

conzty01 requested a review from bnmnetp June 27, 2017 21:37

conzty01 added 5 commits June 29, 2017 08:50

update

ecdd0cd

Resolved Merge Conflict

38489f6

Merge remote-tracking branch 'upstream/master'

0aa73f3

Fetched Upstream Updates

Merge remote-tracking branch 'upstream/master'

2ce9fae

Fetch 7/5/2017

Merge remote-tracking branch 'upstream/master'

df7b98b

Merge Upstream 7/6/2017

bnmnetp suggested changes Jul 7, 2017

View reviewed changes

bnmnetp reviewed Jul 7, 2017

View reviewed changes

Fixed "True" in incorrect language.

98489ca

Merge remote-tracking branch 'upstream/master'

50d68fa

Merge Upstream 7/11 9:23AM

Merge remote-tracking branch 'upstream/master'

dc99429

Fetch Upstream 7/12/17 8:39AM

Updated behavior of reset funcitonality

275adb7

conzty01 added 5 commits July 17, 2017 08:35

Merge remote-tracking branch 'upstream/master'

91a5182

Fetch Upstream 07/17/17 8:36AM

Fixed issue with alert

ad89c9c

Alert now occurs when the server determines an exam is not a candidate for resetting.

Merge branch 'master' of https://github.com/conzty01/RunestoneComponents

8152239

Pull 07/18/17 8:43AM

Merge remote-tracking branch 'upstream/master'

16eb6ce

Merge Upstream 07/18/17 8:49AM

Merge remote-tracking branch 'upstream/master'

67dba64

Fetch upstream 07/19/17 1:05PM

Merge remote-tracking branch 'upstream/master'

63456b8

Fetch Upstream 07/21/17 10:30AM

bnmnetp suggested changes Jul 21, 2017

View reviewed changes

bnmnetp reviewed Jul 21, 2017

View reviewed changes

conzty01 added 3 commits July 24, 2017 11:02

Manual Merge of versions of timed.js and runestonebase.js

1a6b67d

Merge remote-tracking branch 'upstream/master'

e36f2fa

Fetch upstream 3:57PM 7/24/17

Fixed 'undefined tmpArray' bug

dfa2736

bnmnetp approved these changes Jul 26, 2017

View reviewed changes

bnmnetp merged commit dfa2736 into RunestoneInteractive:master Jul 26, 2017


		}

		RunestoneBase.prototype.init = function(opts) {

Uh oh!

Added functionality to reset timed exams. #399

Added functionality to reset timed exams. #399

Uh oh!

Conversation

conzty01 commented Jun 22, 2017

Uh oh!

conzty01 commented Jun 23, 2017

Uh oh!

bnmnetp left a comment

Choose a reason for hiding this comment

Uh oh!

bnmnetp Jul 7, 2017

Choose a reason for hiding this comment

Uh oh!

bnmnetp left a comment

Choose a reason for hiding this comment

Uh oh!

conzty01 commented Jul 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bnmnetp commented Jul 7, 2017

Uh oh!

conzty01 commented Jul 7, 2017

Uh oh!

bnmnetp commented Jul 10, 2017

Uh oh!

conzty01 commented Jul 10, 2017

Uh oh!

bnmnetp commented Jul 10, 2017

Uh oh!

conzty01 commented Jul 10, 2017

Uh oh!

conzty01 commented Jul 10, 2017

Uh oh!

bnmnetp commented Jul 10, 2017

Uh oh!

conzty01 commented Jul 11, 2017

Uh oh!

conzty01 commented Jul 11, 2017

Uh oh!

conzty01 commented Jul 11, 2017

Uh oh!

bnmnetp commented Jul 11, 2017

Uh oh!

bnmnetp commented Jul 11, 2017

Uh oh!

conzty01 commented Jul 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conzty01 commented Jul 14, 2017

Uh oh!

conzty01 commented Jul 14, 2017

Uh oh!

bnmnetp commented Jul 20, 2017

Uh oh!

bnmnetp left a comment

Choose a reason for hiding this comment

Uh oh!

bnmnetp Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

bnmnetp Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

bnmnetp Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

bnmnetp Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

bnmnetp Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

bnmnetp left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

conzty01 commented Jul 7, 2017 •

edited

Loading

conzty01 commented Jul 12, 2017 •

edited

Loading