This repository was archived by the owner on Jun 7, 2023. It is now read-only.
Fix: Use a single DBURL environment variable... #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BUSER/DBPASS/DBHOST/DBNAME.
bnmnetp
reviewed
Jul 5, 2017
Member
bnmnetp
left a comment
bnmnetp
left a comment
There was a problem hiding this comment.
This is a good change, but since its not backward comopatible I'm just going have to find a time to accept it when I can go in and upgrade all of the continuous integration scripts.
Contributor
Author
|
Makes sense. Are these scripts in github somewhere? If so, would you like any help with fixes/upgrades for them? |
Contributor
Author
|
Awesome! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of individual DBUSER/DBPASS/DBHOST/DBNAME. This makes setup a bit easier, and allows supporting other databases. It also cleans cruft by using get_dburl, rather than custom code in many places.