This repository was archived by the owner on Jun 7, 2023. It is now read-only.
Fix to Parsons problems without any separators #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the disabling of the help button. It should have been inside a conditional and only executed if the problem was adaptive. But, now that I have made the help button always active it isn’t needed.
… Parsons problems I found the place where the div class=runestone was added and removed it. This was limiting the Parsons problems to a width of 500 px and we need them to be as large as the activecode. Otherwise you can’t have very long code in your Parsons problems.
# Conflicts: # runestone/parsons/parsons.py
There was a bug with Parsons problems that didn’t have any separators. This fixes it.
# Conflicts: # runestone/parsons/parsons.py
Member
|
@aerenchyma Have you been able to make any progress on unit tests for parsons? I think this is the only one that is missing a selenium test and it would be really great to get that going. |
Contributor
|
@bnmnetp Sorry -- a little bit, but I'm traveling at the moment without a lot of computer/internet access. I'll be back soon and will try to get it going. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the error in Jeff's code and added a conditional to protect against it. When you don't specify any separators it breaks the lines at end of line characters, but that results in one extra empty line. So I needed to guard against this with a line.length > 0.