This repository was archived by the owner on Jun 7, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 223
Fitb and mchoice fixes #427
Merged
bnmnetp
merged 16 commits into
RunestoneInteractive:master
from
bjones1:fitb_mchoice_fixes
Aug 7, 2017
Merged
Fitb and mchoice fixes #427
bnmnetp
merged 16 commits into
RunestoneInteractive:master
from
bjones1:fitb_mchoice_fixes
Aug 7, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assign letters to answers in JS, not in Python, so random looks reasonable.
Provide feedback in a list.
Remove correct/incorrect text -- let authors use their wording instead.
Test for errors in this.
Fix: Error revealed by testing.
Member
|
All tests still pass on master but when I run the tests on this branch, I get It looks like module_fixture_maker now returns more values?? |
Contributor
Author
|
Oops, I forgot to include a fix in my lp branch. I'll push that, which should fix everything. |
Contributor
Author
|
All tests pass on my PC now. |
Member
|
Yep, they all pass for me now too. |
Contributor
Author
|
Great, thanks for taking a look! |
Contributor
Author
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bunch of fixes, along with better testing, of the fitb and mchoice directives.
One change: the JS no longer reports "Correct" or "Incorrect" for multiple choice questions -- it lets the color tell the story; authors can always add these terms if they prefer.