-
Notifications
You must be signed in to change notification settings - Fork 6
[Fix] #244 - 레이아웃 변경 작업을 하였습니다. #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "#244---\uC774\uBBF8\uC9C0-\uAE68\uC9D0-\uC774\uC288"
Changes from all commits
cec4a6d
664809a
b38f8a7
3f15d6f
8d5033e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,24 +7,24 @@ | |
|
|
||
| import Moya | ||
|
|
||
| class NetworkProvider<Provider : TargetType> : MoyaProvider<Provider> { | ||
| func request<Model : Codable>(target : Provider, instance : Model.Type , vc: UIViewController, completion : @escaping(Model) -> ()){ | ||
| class NetworkProvider<Provider: TargetType> : MoyaProvider<Provider> { | ||
| func request<Model: Codable>(target: Provider, instance: Model.Type , vc: UIViewController, completion: @escaping(Model) -> ()){ | ||
| self.request(target) { result in | ||
| switch result { | ||
| /// 서버 통신 성공 | ||
| /// 서버 통신 성공 | ||
| case .success(let response): | ||
| if (200..<300).contains(response.statusCode) { | ||
| if let decodeData = try? JSONDecoder().decode(instance, from: response.data) { | ||
| completion(decodeData) | ||
| } else{ | ||
| } else { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 아차차 요런 부분까지 확인해주다니.. 넘 꼼꼼해요 명진쌤
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 노란 경고 창이 떠서.. ㅎㅎ |
||
| /// decoding error | ||
| vc.showNetworkFailureToast() | ||
| } | ||
| } else { | ||
| /// 응답 코드 400인 경우 | ||
| vc.showNetworkFailureToast() | ||
| } | ||
| /// 서버 통신 실패 | ||
| /// 서버 통신 실패 | ||
| case .failure(let error): | ||
| if let response = error.response { | ||
| if let responseData = String(data: response.data, encoding: .utf8) { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확실히 줄바꿔주는게 낫네용!! 저도 앞으로 신경써서 작성해보겠습니다 👊🏻👊🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고민 해보다가 변경 했는데 좋게 봐주셔서 감사합니다. 🫠