Conversation
Firestar99
requested review from
LegNeato,
eddyb and
fornwall
as code owners
…e backend's `target_override`.
Collaborator
|
You'll need something like this (or the proper fix): |
Without this the skip directives weren't working. This looks to largely be legacy anyway, but tests now run and pass in the correct environments.
We have specific code to handle the path mangling on windows, but for some reason it isn't working for these tests. This is a hack to make them pass on windows.
Member
Author
|
This PR breaks for loops using signed integers, for example the following will not compile anymore: #[spirv(fragment)]
pub fn main(#[spirv(flat)] i: i32) {
for _ in 0..i {}
}This is likely due to a change in core's As a workaround one can use unsigned for loops and casting the index back to a signed integer. I'd suggest merging this for now and addressing the regression later. I've also added it to the changelog so it can't be forgotten. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-picking some of eddyb's nightly updates
For this one the PR's diff is fine