Examples improvements#402
Merged
Merged
Conversation
Also make it include `1` in the output sequence, because that is the first number according to https://oeis.org/A006877.
Currently you can use '+'/'-' on the numeric keypad to adjust the intensity, but lots of keyboards lack a numeric keypad. This commit changes it to use the up and down arrows instead.
nnethercote
requested review from
Firestar99,
LegNeato,
eddyb and
schell
as code owners
eddyb
reviewed
Sep 19, 2025
eddyb
requested changes
Sep 19, 2025
Member
eddyb
left a comment
eddyb
left a comment
There was a problem hiding this comment.
Love this, no real complaints, just a bunch of nitpicks (feel free to ignore most of them tbh), and being reminded of things I'd forgotten about, heh.
nnethercote
force-pushed
the
examples-improvements
branch
4 times, most recently
from
be36be9 to
3a8f4ba
Compare
nnethercote
force-pushed
the
examples-improvements
branch
from
3a8f4ba to
29dbbaf
Compare
Better explain the shaders and runners, and explain how to invoke them, and even document the `+`/`-` feature of the sky shader on ash, which is currently invisible unless you read the code.
nnethercote
force-pushed
the
examples-improvements
branch
from
29dbbaf to
a373bdc
Compare
Contributor
Author
|
Thanks for the review. I have fixed the addressable ones. Should be good to go, now. |
eddyb
approved these changes
Sep 22, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Member
|
Intermittent Internet failure: connection reset |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some improvements to the examples, mostly docs, a little code. Details in the individual commits.