Skip to content

Conversation

@wedsonaf
Copy link

@wedsonaf wedsonaf commented Jul 1, 2021

This allows drivers to call functions in security modules that take
objects for which we have abstractions (e.g., files and tasks) as
arguments.

Based on #410.

Signed-off-by: Wedson Almeida Filho wedsonaf@google.com

@ksquirrel

This comment has been minimized.

@wedsonaf wedsonaf marked this pull request as draft July 1, 2021 22:03
@bjorn3
Copy link
Member

bjorn3 commented Jul 2, 2021

Looks like I was a bit too eager to approve. The rust side changes LGTM, but as the CI shows this still needs the C side to be implemented.

@wedsonaf
Copy link
Author

wedsonaf commented Jul 2, 2021

Looks like I was a bit too eager to approve. The rust side changes LGTM, but as the CI shows this still needs the C side to be implemented.

It looks like some architectures don't define the C functions. I'll update this PR to include C helpers.

This allows drivers to call functions in security modules that take
objects for which we have abstractions (e.g., files and tasks) as
arguments.

Signed-off-by: Wedson Almeida Filho <wedsonaf@google.com>
@ksquirrel
Copy link
Member

Review of 99cedeb11151:

  • ✔️ Commit 99cedeb: Looks fine!

@wedsonaf wedsonaf marked this pull request as ready for review July 2, 2021 18:13
@ojeda ojeda merged commit dcf2391 into Rust-for-Linux:rust Jul 2, 2021
@wedsonaf wedsonaf deleted the lsms branch July 2, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants