Coreaudio compilation failure - bindings generation fail due to old rustfmt bug

[saresend]

Hey, I'm using coreaudio-sys as a dependency for CPAL, and it seems that the pinned v 0.2.0 is failing to compile with the following error:

error: unexpected close delimiter: `]`
    --> /Users/.../coreaudio-sys-a6bbc6ed7b769743/out/coreaudio.rs:2040:33
     |
2040 | #[derive(Copy, Clone)]; 16usize ] , }#[test]
     |                                 ^

error: Could not compile `coreaudio-sys`.

I can't find other sources of people having this issue, so I'm not sure if it is on my end or not.
Thanks!

[mitchmindtree]

Hey thanks for the issue!

This seems to be an issue with older versions of rustfmt, could you possibly try updating to the latest rustfmt that ships with rustup?

I actually came across this too, and I can't see us being the only ones. Perhaps we should try catching this error and then re-generating the bindings without running rustfmt for users relying on older versions of the rust tools.

[tomaka]

Indeed I don't think it's a good idea to run rustfmt on generated bindings which nobody is going to read anyway!

[saresend]

Does cargo automatically run rustfmt on dependencies?

[alexander-irbis]

A simple workaround if someone has no opportunity to update the rustfmt

--- a/build.rs
+++ b/build.rs
@@ -73,6 +73,7 @@ fn main() {
     let bindings = builder
         .trust_clang_mangling(false)
         .derive_default(true)
+        .rustfmt_bindings(false)
         .generate()
         .expect("unable to generate bindings");

[Rhuagh]

Bindgen by default automatically run rust fmt on the generated bindings. This pr disables that automatic fmt

[Rhuagh]

Fixed by #13 .