Added logic for (hopefully) properly detecting framework paths#6
Added logic for (hopefully) properly detecting framework paths#6mitchmindtree merged 1 commit intoRustAudio:masterfrom regexident:frameworks
Conversation
|
This fixes the build on my machine. Is there anything in the way of getting it merged? |
|
@SergejJurecko Same here on my 10.13.4. Thanks! |
|
@mitchmindtree |
|
This fixes my build on 10.13.4 also. |
|
Eventually the issue this PR fixes could cause us to not be able to release support for OSX or iOS on cargo for the Amethyst game engine. So we'd be very grateful if this was merged and released to cargo sooner rather than later. |
|
Someone correct me if I'm wrong but I'm pretty sure this isn't a breaking change, and thus could be released as a patch version. If we could do that then this change could propagate throughout the whole ecosystem without anyone else doing any more work on it. |
|
Sorry all, I'm currently in the middle of the Annapurna circuit with sparse
wifi, I will try to merge this at our next stop when I have access to my
lappy and hopefully have net again. If someone with macos readily available
would like to co-maintain this with me please let me know and I'll make the
changes - I don't always have access to macos these days.
…On Wed, 2 May 2018 at 1:24 am, Jacob Kiesel ***@***.***> wrote:
Someone correct me if I'm wrong but I'm pretty sure this isn't a breaking
change, and thus could be released as a patch version. If we could do that
then this change could propagate throughout the whole ecosystem without
anyone else doing any more work on it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEX_bZh-HX1M5_iaYfhrwzGvLUH9WnKxks5tuLoNgaJpZM4SDgm0>
.
|
688: fix: Temporary patch for coreaudio-sys (mac) r=Xaeroxe,jojolepro a=Rhuagh Can be reverted when RustAudio/coreaudio-sys#6 has been merged and released and propagated through cpal and rodio. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/688) <!-- Reviewable:end --> Co-authored-by: Simon Rönnberg <seamonr@gmail.com>
|
I can co-maintain with you if noone else steps up, I have a mac (High Sierra). |
Attempt at solving issue #5.
I'm not sure how to properly distinguish between device & simulator builds, as those need linking against different frameworks (due to one being ARM, the other Intel).
Should probably also handle a lack of
xcode-selectbetter than just printing "coreaudio-sys could not find frameworks path".