Skip to content

Added logic for (hopefully) properly detecting framework paths#6

Merged
mitchmindtree merged 1 commit intoRustAudio:masterfrom
regexident:frameworks
May 3, 2018
Merged

Added logic for (hopefully) properly detecting framework paths#6
mitchmindtree merged 1 commit intoRustAudio:masterfrom
regexident:frameworks

Conversation

@regexident
Copy link
Contributor

@regexident regexident commented Feb 13, 2018

Attempt at solving issue #5.

I'm not sure how to properly distinguish between device & simulator builds, as those need linking against different frameworks (due to one being ARM, the other Intel).

Should probably also handle a lack of xcode-select better than just printing "coreaudio-sys could not find frameworks path".

@SergejJurecko
Copy link

This fixes the build on my machine. Is there anything in the way of getting it merged?

@flxo
Copy link

flxo commented Apr 27, 2018

@SergejJurecko Same here on my 10.13.4. Thanks!

@Moxinilian
Copy link

Moxinilian commented Apr 28, 2018

@mitchmindtree
Now that rodio depends on it, not merging this breaks a lot of builds on High Sierra.

@Rhuagh
Copy link
Collaborator

Rhuagh commented Apr 28, 2018

This fixes my build on 10.13.4 also.

@Xaeroxe
Copy link

Xaeroxe commented May 1, 2018

Eventually the issue this PR fixes could cause us to not be able to release support for OSX or iOS on cargo for the Amethyst game engine. So we'd be very grateful if this was merged and released to cargo sooner rather than later.

@Xaeroxe
Copy link

Xaeroxe commented May 1, 2018

Someone correct me if I'm wrong but I'm pretty sure this isn't a breaking change, and thus could be released as a patch version. If we could do that then this change could propagate throughout the whole ecosystem without anyone else doing any more work on it.

@mitchmindtree
Copy link
Member

mitchmindtree commented May 2, 2018 via email

bors bot added a commit to amethyst/amethyst that referenced this pull request May 2, 2018
688: fix: Temporary patch for coreaudio-sys (mac) r=Xaeroxe,jojolepro a=Rhuagh

Can be reverted when RustAudio/coreaudio-sys#6 has been merged and released and propagated through cpal and rodio.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/amethyst/amethyst/688)
<!-- Reviewable:end -->


Co-authored-by: Simon Rönnberg <seamonr@gmail.com>
@Rhuagh
Copy link
Collaborator

Rhuagh commented May 2, 2018

I can co-maintain with you if noone else steps up, I have a mac (High Sierra).

@mitchmindtree mitchmindtree merged commit cf3a832 into RustAudio:master May 3, 2018
@regexident regexident deleted the frameworks branch May 4, 2018 07:21
@hfaulds hfaulds mentioned this pull request May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants