Use 100% safe TinyVec instead of SmallVec #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault is only implemented for arrays of size up to 32.
est31
approved these changes
Mar 16, 2020
Member
est31
left a comment
est31
left a comment
There was a problem hiding this comment.
Thanks! Safety is very important for lewton.
TinyVec has an MSRV of 1.36.0 so there is no issue from that side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from SmallVec to TinyVec, which is an implementation of the same idea but in 100% safe code. SmallVec has a less-than-stellar track record in terms of safety.
Sadly this drops the size of pre-allocated segment on the stack to 32 because Default is only implemented for arrays of size up to 32. This did not result in any measurable difference in performance on the samples I've thrown at it (speech, music, both short and long samples, low and high bitrates), but it's possible that I simply haven't found the right sample.