-
Notifications
You must be signed in to change notification settings - Fork 293
Closed
Labels
breakingProposed change that would break the public APIProposed change that would break the public APIenhancementhelp wanted
Description
Context:
Many of the fixes regarding span len require keeping track of something within this function. The only way to do that right now is with interior mutability (Cell/RefCell/Mutex etc). As far as I know the only reason current_span_len takes &self is that it simply did not need &mut self.
Advantage:
The code around these fixes will become simpler and more maintainable. Enables optimizations by moving mutations from a conditional space in Iterator::next to current_span_len.
Disadvantage:
Can not call current_span_len while holding a reference to Source somewhere else. Unknown if that is used anywhere.
Help:
Need input whether this change is possible and worth it.
Metadata
Metadata
Assignees
Labels
breakingProposed change that would break the public APIProposed change that would break the public APIenhancementhelp wanted