Skip to content

Conversation

@yara-blue
Copy link
Member

This will enable sending the wav somewhere else then the local filesystem. Examples are: send over tcp/http, collect multiple in a tar (my usecase).

@yara-blue
Copy link
Member Author

yara-blue commented Aug 29, 2025

needs

  • better name
  • change log entry
  • possibly rename the existing one

This will enable sending the wav somewhere else then the local
filesystem. Examples are: send over tcp/http, collect multiple
in a tar (my usecase).
It does not make sense to get them by ref. Since we will not return
till they are fully exhausted (or never if the source is infinite).
Therefore there is no use to borrowing
Copy link
Member

@roderickvd roderickvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you recording? 😄

@yara-blue yara-blue closed this Aug 30, 2025
@yara-blue yara-blue reopened this Aug 30, 2025
@yara-blue
Copy link
Member Author

What are you recording? 😄

Improving the VOIP in zed, needed a way to write recent audio to disk in case we run into audio issues. Need the writer call since I want to record each user in a call to a single tar file. (Which the user triggering the record can then send me to debug)

@roderickvd
Copy link
Member

<offtopic> You are contributing to Zed and using VoIP calls? Cool, I'm a Zed user too. </offtopic>

@yara-blue
Copy link
Member Author

You are contributing to Zed and using VoIP calls? Cool, I'm a Zed user too.

Yeah I joined their team last month. Really like the collaborative editing mode, its so much nicer to pair on a PR then use gits terrible interface. We should try that for your giant PR (if you're up for it).

@roderickvd
Copy link
Member

You are contributing to Zed and using VoIP calls? Cool, I'm a Zed user too.

Yeah I joined their team last month. Really like the collaborative editing mode, its so much nicer to pair on a PR then use gits terrible interface. We should try that for your giant PR (if you're up for it).

Never used it before, but sure! Only question I have is how it works with beer.

@yara-blue
Copy link
Member Author

few notes on the builder, should be typed as in:
configuring .wav on the builder should return a WavOutputBuilder. That builder then has the specific options relevant to wav.

The wav writer returns an error if we do not write a whole frame.
This prevents that error by only writing whole frames.
@yara-blue yara-blue merged commit 47dab16 into master Sep 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants