-
Notifications
You must be signed in to change notification settings - Fork 293
add wav output method which takes writer #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
needs
|
This will enable sending the wav somewhere else then the local filesystem. Examples are: send over tcp/http, collect multiple in a tar (my usecase).
a928a12 to
1dd9266
Compare
It does not make sense to get them by ref. Since we will not return till they are fully exhausted (or never if the source is infinite). Therefore there is no use to borrowing
roderickvd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are you recording? 😄
Improving the VOIP in zed, needed a way to write recent audio to disk in case we run into audio issues. Need the writer call since I want to record each user in a call to a single tar file. (Which the user triggering the record can then send me to debug) |
|
<offtopic> You are contributing to Zed and using VoIP calls? Cool, I'm a Zed user too. </offtopic> |
Yeah I joined their team last month. Really like the collaborative editing mode, its so much nicer to pair on a PR then use gits terrible interface. We should try that for your giant PR (if you're up for it). |
Never used it before, but sure! Only question I have is how it works with beer. |
|
few notes on the builder, should be typed as in: |
The wav writer returns an error if we do not write a whole frame. This prevents that error by only writing whole frames.
c7f3f48 to
82514bd
Compare
9e21180 to
ac6e228
Compare
This will enable sending the wav somewhere else then the local filesystem. Examples are: send over tcp/http, collect multiple in a tar (my usecase).