Conversation
tarcieri
commented
Mar 19, 2022
Comment on lines
-35
to
+36
| armv8 = ["aes/armv8", "ghash/armv8"] # nightly-only | ||
| force-soft = ["aes/force-soft", "ghash/force-soft"] | ||
| armv8 = ["ghash/armv8"] # nightly-only | ||
| force-soft = ["ghash/force-soft"] |
Member
Author
There was a problem hiding this comment.
It seems unfortunate there's no longer a way to transitively toggle on support for these across crates.
The cfg-based approach seems okay, but IMO there should be a single cfg which can force soft implementations across all crates, or force nightly armv8 support, rather than having to instruct people to pass two different cfgs for both aes and ghash
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
==========================================
- Coverage 87.95% 87.90% -0.05%
==========================================
Files 40 40
Lines 1959 1960 +1
==========================================
Hits 1723 1723
- Misses 236 237 +1
Continue to review full report at Codecov.
|
tarcieri
force-pushed
the
aes-gcm/bump-aes-to-v0.8
branch
from
5d05d05 to
f9c7196
Compare
tarcieri
force-pushed
the
aes-gcm/bump-aes-to-v0.8
branch
from
f9c7196 to
81827f5
Compare
tarcieri
changed the title
aes crate to v0.8aes crate to v0.8
Merged
tarcieri
added a commit
that referenced
this pull request
Sep 21, 2023
In #409, for whatever reason I moved the application of the keystream from after the tag check to before. This means the keystream is applied unilaterally, instead of only when tag verification is successful. Sadly, there was a TODO to test for this. A test has been added to ensure the buffer is unmodified on tag verification failure. It was red/green tested to ensure it caught the previous bug, and that the fix corrects it. This is being tracked as GHSA-423w-p2w9-r7vq (currently embargoed).
tarcieri
added a commit
that referenced
this pull request
Sep 21, 2023
In #409, for whatever reason I moved the application of the keystream from after the tag check to before. This means the keystream is applied unilaterally, instead of only when tag verification is successful. Sadly, there was a TODO to test for this. A test has been added to ensure the buffer is unmodified on tag verification failure. It was red/green tested to ensure it caught the previous bug, and that the fix corrects it. This is being tracked as GHSA-423w-p2w9-r7vq (currently embargoed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.