aes-siv: bump aes crate to v0.8; MSRV 1.56+#431
Merged
Conversation
tarcieri
commented
Jun 26, 2022
Comment on lines
-270
to
+275
| mac.update(&Tag::default()); | ||
| Mac::update(mac, &Tag::default()); |
Member
Author
There was a problem hiding this comment.
I'm still not exactly sure why but I had to disambiguate these:
Compiling aes-siv v0.7.0-pre (/Users/tony/src/RustCrypto/AEADs/aes-siv)
error[E0034]: multiple applicable items in scope
--> aes-siv/src/siv.rs:275:9
|
275 | mac.update(&Tag::default());
| ^^^^^^ multiple `update` found
|
note: candidate #1 is defined in the trait `Mac`
--> /Users/tony/.cargo/registry/src/github.com-1ecc6299db9ec823/digest-0.10.3/src/mac.rs:38:5
|
38 | fn update(&mut self, data: &[u8]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: candidate #2 is defined in the trait `Update`
--> /Users/tony/.cargo/registry/src/github.com-1ecc6299db9ec823/digest-0.10.3/src/lib.rs:77:5
|
77 | fn update(&mut self, data: &[u8]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: disambiguate the associated function for candidate #1
|
275 | Mac::update(&mut mac, &Tag::default());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: disambiguate the associated function for candidate #2
|
275 | Update::update(&mut mac, &Tag::default());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...which occurs even if the Update trait hasn't been imported or bounded upon, nor is it a bound of Mac, so I'm not sure why this is ambiguous
cc @newpavlov
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
- Coverage 87.38% 87.28% -0.10%
==========================================
Files 40 40
Lines 1958 1959 +1
==========================================
- Hits 1711 1710 -1
- Misses 247 249 +2
Continue to review full report at Codecov.
|
cff552e to
e4a7e30
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.