Enable getrandom feature by defaut; improve docs#446
Merged
Conversation
The `getrandom` feature transitively activates `aead/getrandom` and makes `aead::OsRng` available. RNG access is pretty essential for successful use of these crates. It's needed to generate random keys as the very least. The documentation has also been updated to show the generation of random keys, as opposed to using a hardcoded one.
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
=======================================
Coverage 87.21% 87.21%
=======================================
Files 40 40
Lines 1955 1955
=======================================
Hits 1705 1705
Misses 250 250
Continue to review full report at Codecov.
|
This was referenced Jul 25, 2022
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
getrandomfeature transitively activatesaead/getrandomand makesaead::OsRngavailable.RNG access is pretty essential for successful use of these crates. It's needed to generate random keys as the very least.
The documentation has also been updated to show the generation of random keys, as opposed to using a hardcoded one.