Skip to content

Make ChaChaPoly1305 implement ZeroizeOnDrop#447

Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom
fjarri:zeroize-chacha
Jul 29, 2022
Merged

Make ChaChaPoly1305 implement ZeroizeOnDrop#447
tarcieri merged 1 commit intoRustCrypto:masterfrom
fjarri:zeroize-chacha

Conversation

@fjarri
Copy link
Contributor

@fjarri fjarri commented Jul 29, 2022

The zeroize-on-drop code was present before, but this PR announces that explicitly in the public API.

Some notes:

  • To keep changes to the minimum, I did not add a Zeroize impl (probably not a good idea anyway)
  • Had to restrict zeroize to >=1.5, hopefully that's ok.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #447 (4cfe477) into master (d6f510e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   87.21%   87.21%           
=======================================
  Files          40       40           
  Lines        1955     1955           
=======================================
  Hits         1705     1705           
  Misses        250      250           
Impacted Files Coverage Δ
chacha20poly1305/src/lib.rs 76.92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6f510e...4cfe477. Read the comment docs.

@tarcieri tarcieri merged commit cc0b7d6 into RustCrypto:master Jul 29, 2022
@tarcieri
Copy link
Member

Thanks!

@tarcieri tarcieri mentioned this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants