Conversation
Member
Author
|
Well, this is odd. Several of the doctests started failing when built without the running 2 tests
test aes-gcm-siv/src/lib.rs - (line 213) ... ignored
test aes-gcm-siv/src/lib.rs - (line 174) ... FAILEDIt's not ignoring them in this case for some reason (though curiously, the ones that depend on Also strange is the actual logic doing the feature-based gating didn't change. |
Member
Author
|
Wow, that's super weird, I can get it to succeed by completely inverting the logic: #![cfg_attr(feature = "getrandom", doc = "```ignore")]
#![cfg_attr(not(feature = "getrandom"), doc = "```")]That makes absolutely no sense! |
tarcieri
added a commit
that referenced
this pull request
Dec 26, 2025
- Runs tests with `--lib` and adds separate `--doc` step - Run tests with debug builds and adds a separate `--release` step This should test more combinations (both debug and release builds), but largely serves as a workaround for the weirdness happening in #752 where feature-gating seems to be working incorrectly in the doctests.
tarcieri
added a commit
that referenced
this pull request
Dec 26, 2025
- Runs tests with `--lib` and adds separate `--doc` step - Run tests with debug builds and adds a separate `--release` step This should test more combinations (both debug and release builds), but largely serves as a workaround for the weirdness happening in #752 where feature-gating seems to be working incorrectly in the doctests.
tarcieri
added a commit
that referenced
this pull request
Dec 26, 2025
- Runs tests with `--lib` and adds separate `--doc` step - Run tests with debug builds and adds a separate `--release` step This should test more combinations (both debug and release builds), but largely serves as a workaround for the weirdness happening in #752 where feature-gating seems to be working incorrectly in the doctests.
tarcieri
added a commit
that referenced
this pull request
Dec 26, 2025
- Runs tests with `--lib` and adds separate `--doc` step - Run tests with debug builds and adds a separate `--release` step This should test more combinations (both debug and release builds), but largely serves as a workaround for the weirdness happening in #752 where feature-gating seems to be working incorrectly in the doctests.
tarcieri
added a commit
that referenced
this pull request
Dec 26, 2025
- Runs tests with `--lib` and adds separate `--doc` step - Run tests with debug builds and adds a separate `--release` step This should test more combinations (both debug and release builds), but largely serves as a workaround for the weirdness happening in #752 where feature-gating seems to be working incorrectly in the doctests.
This is primarily the documentation changes for the newly introduced `Generate` trait which subsumed the previous RNG APIs. See also: - RustCrypto/traits#2096 - RustCrypto/traits#2098
tarcieri
force-pushed
the
aead/v0.6.0-rc.4
branch
from
e5c7985 to
224c33d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is primarily the documentation changes for the newly introduced
Generatetrait which subsumed the previous RNG APIs.See also:
Generatetrait traits#2096