Merged
Conversation
tarcieri
force-pushed
the
kem/remove-associated-error-types
branch
from
af33133 to
8fb266c
Compare
Companion PR to RustCrypto/traits#2216 The traits were changed to be infallible, since all of the current implementations are, and it's a pleasure to work with. However, things get trickier if we want a byte-oriented interface for ciphertexts/shared secrets as is proposed in RustCrypto/traits#2220 since `dhkem` needs decapsulation to handle point validation, which is fallible. Everything except `dhkem` can support infallible decapsulation, though.
tarcieri
force-pushed
the
kem/remove-associated-error-types
branch
from
8fb266c to
9e0d625
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR to RustCrypto/traits#2216
The traits were changed to be infallible, since all of the current implementations are, and it's a pleasure to work with.
However, things get trickier if we want a byte-oriented interface for ciphertexts/shared secrets as is proposed in RustCrypto/traits#2220 since
dhkemneeds decapsulation to handle point validation, which is fallible.Everything except
dhkemcan support infallible decapsulation, though.