Skip to content

Minor post-transfer changes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dignifiedquire merged 3 commits into from
Dec 3, 2018
Merged

Minor post-transfer changes #1

dignifiedquire merged 3 commits into from
Dec 3, 2018

Conversation

@newpavlov
Copy link
Member

@newpavlov newpavlov commented Dec 3, 2018 •
edited
Loading

Not sure about the minimum supported Rust version for CI, for now it's 1.27.

dignifiedquire
dignifiedquire approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@newpavlov
Copy link
Member Author

newpavlov commented Dec 3, 2018

If you would like to continue being the main maintainer (and developer) of this crate, then I think the one to merge PRs (including this one) should be you. What do you think?

@dignifiedquire
Copy link
Member

dignifiedquire commented Dec 3, 2018

If you would like to continue being the main maintainer (and developer) of this crate, then I think the one to merge PRs (including this one) should be you. What do you think?

Makes sense, will merge once CI is happy and publish an initial version to crates.io later today

@newpavlov
Copy link
Member Author

newpavlov commented Dec 3, 2018

key::tests::key_generation_128 has failed with "unwrap() on None". I've restarted the test and it got "fixed". IIUC you have non-determinism in your tests and implementation has a bug.

Ideally we should be able to use deterministic RNG source for tests and OS RNG for everything else, but unfortunately it's not that easy right now.

@newpavlov
Copy link
Member Author

newpavlov commented Dec 3, 2018

BTW it would be nice to also add fuzzing testing, see cargo-fuzz.

@dignifiedquire dignifiedquire mentioned this pull request Dec 3, 2018
Closed
@dignifiedquire
Copy link
Member

dignifiedquire commented Dec 3, 2018

key::tests::key_generation_128 has failed with "unwrap() on None". I've restarted the test and it got "fixed". IIUC you have non-determinism in your tests and implementation has a bug.

Argh :/ I saw this once before in a project that uses this, but didn't realize it comes from here.

Created an issue #2

BTW it would be nice to also add fuzzing testing, see cargo-fuzz.

Yes, definitely need this #3

@dignifiedquire dignifiedquire merged commit d3e5d89 into master Dec 3, 2018
@newpavlov newpavlov deleted the transfer branch December 13, 2018 09:50
jarlungoodoo73
jarlungoodoo73 approved these changes Jan 20, 2026
View reviewed changes
Copy link

@jarlungoodoo73 jarlungoodoo73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete all red lines, green lines are all go, there the fix. Review, fix, finish

Cargo.toml
[package]
name = "rsa"
version = "0.1.0"
authors = ["dignifiedquire <dignifiedquire@gmail.com>"]

This comment was marked as spam.

Sign in to view

Cargo.toml
name = "rsa"
version = "0.1.0"
authors = ["dignifiedquire <dignifiedquire@gmail.com>"]
description = "RSA implementation in Rust"

This comment was marked as spam.

Sign in to view

Cargo.toml
authors = ["RustCrypto Developers", "dignifiedquire <dignifiedquire@gmail.com>"]
description = "Pure Rust RSA implementation"
license = "MIT OR Apache-2.0"
homepage = "https://github.com/dignifiedquire/rust-rsa"

This comment was marked as spam.

Sign in to view

Cargo.toml
description = "Pure Rust RSA implementation"
license = "MIT OR Apache-2.0"
homepage = "https://github.com/dignifiedquire/rust-rsa"
repository = "https://github.com/dignifiedquire/rust-rsa"

This comment was marked as spam.

Sign in to view

Cargo.toml
license = "MIT OR Apache-2.0"
homepage = "https://github.com/dignifiedquire/rust-rsa"
repository = "https://github.com/dignifiedquire/rust-rsa"

This comment was marked as spam.

Sign in to view

README.md
# RSA
[![crates.io](https://img.shields.io/crates/v/rsa.svg)](https://crates.io/crates/rsa) [![Documentation](https://docs.rs/rsa/badge.svg)](https://docs.rs/rsa) [![Build Status](https://travis-ci.org/RustCrypto/RSA.svg?branch=master)](https://travis-ci.org/RustCrypto/RSA) [![dependency status](https://deps.rs/repo/github/RustCrypto/RSA/status.svg)](https://deps.rs/repo/github/RustCrypto/RSA)

> A portable RSA implementation in Rust.

This comment was marked as spam.

Sign in to view

README.md

## License

MIT or Apache 2.0

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dignifiedquire dignifiedquire dignifiedquire approved these changes

+1 more reviewer

@jarlungoodoo73 jarlungoodoo73 jarlungoodoo73 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@newpavlov @dignifiedquire @jarlungoodoo73