Add RsaPublicKey::new_with_max_size; 4096-bit default max#176
Merged
Add RsaPublicKey::new_with_max_size; 4096-bit default max#176
RsaPublicKey::new_with_max_size; 4096-bit default max#176Conversation
This constructor accepts a configurable maximum key size which can be used in applications that need to deal with unusually large RSA public keys, such as OpenPGP. With the ability to configure an upper limit, this makes it possible to lower the default maximum key size to 4096-bits, which is a reasonable upper limit for most applications. Fixes #166
tarcieri
force-pushed
the
rsapublickey-new-with-max-size
branch
from
53af215 to
1e8b392
Compare
Member
dignifiedquire
left a comment
dignifiedquire
left a comment
There was a problem hiding this comment.
lgtm, can you add a test for the new defaults?
Member
Author
|
@dignifiedquire added |
dignifiedquire
approved these changes
Aug 9, 2022
This was referenced Oct 10, 2022
Merged
Br1ght0ne
added a commit
to aletheia-rs/RSA
that referenced
this pull request
Nov 10, 2022
…ustCrypto#176)" This reverts commit e7f4810.
takumi-earth
pushed a commit
to earthlings-dev/RSA
that referenced
this pull request
Jan 27, 2026
…to#176) This constructor accepts a configurable maximum key size which can be used in applications that need to deal with unusually large RSA public keys, such as OpenPGP. With the ability to configure an upper limit, this makes it possible to lower the default maximum key size to 4096-bits, which is a reasonable upper limit for most applications. Fixes RustCrypto#166
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This constructor accepts a configurable maximum key size which can be used in applications that need to deal with unusually large RSA public keys, such as OpenPGP.
With the ability to configure an upper limit, this makes it possible to lower the default maximum key size to 4096-bits, which is a reasonable upper limit for most applications.
Fixes #166