Use namespaced features for serde; MSRV 1.60#251
Merged
Conversation
Gets rid of the `serde_crate` hacks. Weak/namespaced features should also make it possible to make more of the functionality in this crate optional.
dignifiedquire
approved these changes
Jan 17, 2023
tarcieri
added a commit
that referenced
this pull request
Jan 19, 2023
This reverts commit da1997d. I was probably over-eager on this: it's a breaking change. There are probably some non-breaking changes we can make first, and when we're ready to make breaking changes again, we can revert the revert.
tarcieri
added a commit
that referenced
this pull request
Jan 19, 2023
This reverts commit da1997d. I was probably over-eager on this: it's a breaking change. There are probably some non-breaking changes we can make first, and when we're ready to make breaking changes again, we can revert the revert.
takumi-earth
pushed a commit
to earthlings-dev/RSA
that referenced
this pull request
Jan 27, 2026
Gets rid of the `serde_crate` hacks. Weak/namespaced features should also make it possible to make more of the functionality in this crate optional.
takumi-earth
pushed a commit
to earthlings-dev/RSA
that referenced
this pull request
Jan 27, 2026
…" (RustCrypto#254) This reverts commit da1997d. I was probably over-eager on this: it's a breaking change. There are probably some non-breaking changes we can make first, and when we're ready to make breaking changes again, we can revert the revert.
takumi-earth
pushed a commit
to earthlings-dev/RSA
that referenced
this pull request
Jan 27, 2026
Reverts-the-revert from RustCrypto#254, reinstating RustCrypto#251 This reverts commit 26f38ad. Since we need to upgrade `pkcs1` and `pkcs8`, which are MSRV 1.65, now is a good time to start making brekaing changes again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets rid of the
serde_cratehacks.Weak/namespaced features should also make it possible to make more of the functionality in this crate optional.