Skip to content

fix: do not panic on a prime being 1 when loading a secret key #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dignifiedquire merged 2 commits into from
Jan 6, 2026
+20 −12
Merged

fix: do not panic on a prime being 1 when loading a secret key #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
861654e
chore(deps): bump num-bigint-dig
dignifiedquire Dec 5, 2025
39d4d8a
fix: do not panic on a prime being 1
dignifiedquire Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ readme = "README.md"
rust-version = "1.65"

[dependencies]
num-bigint = { version = "0.8.2", features = ["i128", "prime", "zeroize"], default-features = false, package = "num-bigint-dig" }
num-bigint = { version = "0.8.6", features = ["i128", "prime", "zeroize"], default-features = false, package = "num-bigint-dig" }
num-traits = { version= "0.2.9", default-features = false, features = ["libm"] }
num-integer = { version = "0.1.39", default-features = false }
rand_core = { version = "0.6.4", default-features = false }
Expand Down
19 changes: 17 additions & 2 deletions src/key.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ impl RsaPrivateKey {
let mut m = BigUint::one();
for prime in &self.primes {
// Any primes ≤ 1 will cause divide-by-zero panics later.
Copy link
Member

@tarcieri tarcieri Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment could perhaps say that 0 and 1 are not prime numbers, but...

if *prime < BigUint::one() {
if *prime <= BigUint::one() {
return Err(Error::InvalidPrime);
}
m *= prime;
Expand Down Expand Up @@ -538,7 +538,7 @@ mod tests {
use crate::algorithms::rsa::{rsa_decrypt_and_check, rsa_encrypt};

use hex_literal::hex;
use num_traits::{FromPrimitive, ToPrimitive};
use num_traits::{FromPrimitive, ToPrimitive, Zero};
use pkcs8::DecodePrivateKey;
use rand_chacha::{rand_core::SeedableRng, ChaCha8Rng};

Expand Down Expand Up @@ -841,4 +841,19 @@ mod tests {

assert_eq!(key.d(), ref_key.d());
}

#[test]
fn test_key_invalid_primes() {
let e = RsaPrivateKey::from_components(
BigUint::from_u64(239).unwrap(),
BigUint::from_u64(185).unwrap(),
BigUint::zero(),
vec![
BigUint::from_u64(1).unwrap(),
BigUint::from_u64(239).unwrap(),
],
)
.unwrap_err();
assert_eq!(e, Error::InvalidPrime);
}
}