Ensure DSA signatures are encoded according to spec#115
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom May 17, 2023
Merged
Ensure DSA signatures are encoded according to spec#115tarcieri merged 1 commit intoRustCrypto:masterfrom
tarcieri merged 1 commit intoRustCrypto:masterfrom
Conversation
Contributor
Author
|
With this change in place I can successfully validate DSA signatures emitted by the upstream |
nresare
force-pushed
the
openssh_dsa_signature_encoding
branch
from
90fa201 to
62d9063
Compare
tarcieri
reviewed
May 17, 2023
Member
|
I was surprised at first this wasn't caught by a test, but I guess the only test ensures it can verify its own signatures: https://github.com/RustCrypto/SSH/blob/master/ssh-key/tests/sshsig.rs#L121-L135 It'd probably be good to have a test it can verify an OpenSSH-generated DSA signature. |
This change implements the raw encoding and decoding of DSA signatures according to RFC4253 Section 6.6 instead of relying on the internal representation in the dsa crate. See RustCrypto#114 for additional detail. This change also includes a test case, verifying that we can verify the response from ssh-agent for a DSA signing request.
nresare
force-pushed
the
openssh_dsa_signature_encoding
branch
from
62d9063 to
ba8be05
Compare
Contributor
Author
|
Thank you for the quick review. Please see the updated diff with a previously failing test case verifying a signature generated by ssh-agent |
Member
|
Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements the raw encoding and decoding of DSA signatures according to RFC4253 Section 6.6 instead of relying on the internal representation in the dsa crate. See #114 for additional detail.