ssh-encoding: remove Encoding::Error; add LabelError#124
Merged
Conversation
tarcieri
force-pushed
the
ssh-encoding/remove-encode-err-type-add-labelerror
branch
3 times, most recently
from
11b7ec0 to
458c014
Compare
Removes the associated `Encoding::Error` type as well as `Label::Error`, using `ssh_encoding::Error` as the type. Adds a `LabelError` type which captures the invalid label when the `alloc` feature has been enabled for display purposes. This is used as the error type for `FromStr` impls, so invalid labels can be propagated properly.
tarcieri
force-pushed
the
ssh-encoding/remove-encode-err-type-add-labelerror
branch
from
458c014 to
35a5770
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the associated
Encoding::Errortype as well asLabel::Error, usingssh_encoding::Erroras the type.The rationale is error customization is primarily useful for decoding, not encoding. This change is a simplification.
Adds a
LabelErrortype which captures the invalid label when theallocfeature has been enabled for display purposes. This is used as the error type forFromStrimpls, so invalid labels can be propagated properly.