Conversation
tarcieri
reviewed
Jan 29, 2025
Member
tarcieri
left a comment
tarcieri
left a comment
There was a problem hiding this comment.
I guess I'm confused why the non-hazmat APIs use 9 blocks instead of 8, but this otherwise seems fine
Member
Author
|
See UPD to this comment. It has shown a better performance on several (AMD) CPUs which I've tested the code. There may be issues with my microbenchmarks, but we can easily change the numbers in future based on new data. I guess a power-of-two parallel block size may be better for chunking, so we need to test this. |
Member
|
It would probably be good to test the impact on full AEADs. Seems like having an odd number of blocks is going to make optimizing parallel pipelining (which we don't do, because it makes things slower already) that much harder: RustCrypto/AEADs#74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backends were changed to use a different number of parallel blocks, so the alias is now used only by hazmat functions.
Closes #462