Modular inversion improvements#263
Merged
tarcieri merged 3 commits intoRustCrypto:masterfrom Sep 2, 2023
Merged
Conversation
Member
|
@fjarri needs a rebase |
Contributor
Author
|
#267 should go in first, then I'll rebase on top of that. |
fjarri
force-pushed
the
more-modular
branch
2 times, most recently
from
1a13201 to
af94b47
Compare
Contributor
Author
|
Rebased. |
tarcieri
approved these changes
Sep 2, 2023
fjarri
commented
Sep 2, 2023
| /// Computes the multiplicative inverse of `self` mod `modulus`. | ||
| /// Returns `(inverse, CtChoice::TRUE)` if an inverse exists, | ||
| /// otherwise `(undefined, CtChoice::FALSE)`. | ||
| pub fn inv_mod(&self, modulus: &Self) -> (Self, CtChoice) { |
Contributor
Author
There was a problem hiding this comment.
Just realized, it could have been made const.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rem()which rendered it uselessinv_mod2k()constant-time both inselfandkinv_mod2k()toinv_mod2k_vartime()inv_mod2k_vartime()clearer and fix the attributioninv_mod()that supports both even and odd moduli (works via RNS andinv_mod2k()/inv_odd_mod(); another approach is binary GCD (see Constant-time GCD #227 for more info) which may or may not be faster, but is definitely more complicated)Note that this PR does not introduce any backwards-incompatible changes (except for the performance regression for the users of
inv_mod2k()).Possible additions:
inv_mod2k_bounded(), for the cases where a bound onkis known.inv_mod_vartime()(that callsinv_mod2k_vartime()internally, which would lead to a significant performance gain)(questions involving breaking changes are moved to #268)