RsaPssParams and RsaOaepParams fixes#1010
Merged
tarcieri merged 2 commits intoRustCrypto:masterfrom Apr 18, 2023
Merged
Conversation
Contributor
lumag
commented
Apr 18, 2023
lumag
commented
- Use NULL parameters for digest params (as required by mozilla)
- Add functions to construct known-good parameters.
Obviously Mozilla policy insists on having NULL parameters for MD/SHA algorithm identifiers. Change RsaPssParams/RsaOaepParams defaults to use NULL instead of empty parameters. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Contributor
Author
tarcieri
reviewed
Apr 18, 2023
tarcieri
reviewed
Apr 18, 2023
Member
|
This looks mostly ok though I'm a bit curious about the usage of |
Implement RsaPssParams::new() and RsaOaepParams::new(), two functions to generate correct parameters for the provided Digest and data. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Merged
Contributor
Author
|
@tarcieri thank you! |
baloo
added a commit
to baloo/formats
that referenced
this pull request
May 23, 2024
baloo
added a commit
to baloo/formats
that referenced
this pull request
May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.