Skip to content

spki: fix OidUnknown reporting #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Apr 4, 2024
Merged

spki: fix OidUnknown reporting #1378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spki/src/algorithm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ impl<Params> AlgorithmIdentifier<Params> {
if self.oid == expected_oid {
Ok(expected_oid)
} else {
Err(Error::OidUnknown { oid: expected_oid })
Err(Error::OidUnknown { oid: self.oid })
}
}
}
Expand All @@ -122,7 +122,7 @@ impl<'a> AlgorithmIdentifierRef<'a> {
if actual_oid == expected_oid {
Ok(actual_oid)
} else {
Err(Error::OidUnknown { oid: expected_oid })
Err(Error::OidUnknown { oid: actual_oid })
Copy link
Copy Markdown
Member Author

@tarcieri tarcieri Apr 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could probably use tests.

Perhaps the it should also carry the expected OID if available.

Copy link
Copy Markdown
Member

@baloo baloo Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding the expected should be cheap.

}
}

Expand Down