pkcs5: allow empty algId prf parameter for PBES2 params #1521
Merged
tarcieri merged 5 commits intoRustCrypto:masterfrom Sep 17, 2024
Merged
pkcs5: allow empty algId prf parameter for PBES2 params #1521tarcieri merged 5 commits intoRustCrypto:masterfrom
tarcieri merged 5 commits intoRustCrypto:masterfrom
Conversation
Member
Which ones? Can you include a reference as to how the test vector you're providing was generated, at least in the comments? |
Contributor
Author
|
Specifically, this: https://github.com/smallstep/cli I have added a note in the comments. |
tarcieri
approved these changes
Sep 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale: some applications and libraries produce PBES2/PBKDF2 structures without the terminating NULL value specified in the prf algorithm field.
This PR relaxes the decoding requirements.
According to RFC4231 the NULL parameter should be present but is not an absolute requirement.
See for example this issue: ancwrd1/p12-keystore#2