sec1: upgrade to edition 2024; bump MSRV to 1.85#1666
Merged
tarcieri merged 2 commits intoRustCrypto:masterfrom Feb 23, 2025
Merged
sec1: upgrade to edition 2024; bump MSRV to 1.85#1666tarcieri merged 2 commits intoRustCrypto:masterfrom
tarcieri merged 2 commits intoRustCrypto:masterfrom
Conversation
baloo
force-pushed
the
baloo/sec1/edition-2024
branch
from
4ce2139 to
0f1354f
Compare
baloo
force-pushed
the
baloo/sec1/edition-2024
branch
from
0f1354f to
38d5088
Compare
baloo
force-pushed
the
baloo/sec1/edition-2024
branch
from
38d5088 to
2f3a890
Compare
Member
|
@baloo sidebar: |
tarcieri
approved these changes
Feb 23, 2025
Member
Author
|
I actually don't know if we need to bump editions for const-oid, der, pkcs*, or spki. The only reason I'm seeing is to keep the workspace together? But they otherwise do not depend on anything edition 2024? |
Member
|
@baloo now is our opportunity to bump the edition, we should just do it everywhere |
tarcieri
pushed a commit
to RustCrypto/traits
that referenced
this pull request
Feb 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sec1gets excluded from the workspace temporarily until we getelliptic-curve's edition bumped