base64ct: downgrade edition to 2021; MSRV 1.81#1702
Merged
Conversation
We had some complaints about the steep MSRV upgrade from 1.60 to 1.85 which occurred in the 1.7.0 release (#1695). This lowers the MSRV to just what we need for `core::error::Error` support, downgrading the edition in the process. We can bump edition in a future release, once 1.85 has been out longer. Closes #1695
Member
Author
|
Aah that's fun, need to move it out of the workspace too |
Merged
tarcieri
added a commit
that referenced
this pull request
May 15, 2025
We kept `base64ct` out of the toplevel workspace because we can't run tests on it with its previous MSRV of 1.81 because that compiler can't recognize the newer edition on all of the other crates in the workspace. We originally attempted this upgrade in #1670 but reverted it in #1702 due to complaints we received in #1695. Now that the needed MSRV of 1.85 is `N-2` of the current 1.87 stable, we can hopefully perform this upgrade without receiving as many complaints. Several other crates have bumped edition to 2024 already, and edition upgrades are a time when MSRV bumps like this should be expected.
tarcieri
added a commit
that referenced
this pull request
May 15, 2025
We kept `base64ct` out of the toplevel workspace because we can't run tests on it with its previous MSRV of 1.81 because that compiler can't recognize the newer edition on all of the other crates in the workspace. We originally attempted this upgrade in #1670 but reverted it in #1702 due to complaints we received in #1695. Now that the needed MSRV of 1.85 is `N-2` of the current 1.87 stable, we can hopefully perform this upgrade without receiving as many complaints. Several other crates have bumped edition to 2024 already, and edition upgrades are a time when MSRV bumps like this should be expected.
tarcieri
added a commit
that referenced
this pull request
May 15, 2025
) We kept `base64ct` out of the toplevel workspace because we can't run tests on it with its previous MSRV of 1.81 because that compiler can't recognize the newer edition on all of the other crates in the workspace. We originally attempted this upgrade in #1670 but reverted it in #1702 due to complaints we received in #1695. Now that the needed MSRV of 1.85 is `N-2` of the current 1.87 stable, we can hopefully perform this upgrade without receiving as many complaints. Several other crates have bumped edition to 2024 already, and edition upgrades are a time when MSRV bumps like this should be expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some complaints about the steep MSRV upgrade from 1.60 to 1.85 which occurred in the 1.7.0 release (#1695).
This lowers the MSRV to just what we need for
core::error::Errorsupport, downgrading the edition in the process.We can bump edition in a future release, once 1.85 has been out longer.
Closes #1695