x509-cert: remove unnecessary builder feature activations#1709
Merged
baloo merged 1 commit intoRustCrypto:masterfrom Apr 22, 2025
MihaelBercic:default-features
Merged
x509-cert: remove unnecessary builder feature activations#1709baloo merged 1 commit intoRustCrypto:masterfrom MihaelBercic:default-features
builder feature activations#1709baloo merged 1 commit intoRustCrypto:masterfrom
MihaelBercic:default-features
Conversation
baloo
reviewed
Mar 12, 2025
x509-cert/Cargo.toml
Outdated
| [dependencies] | ||
| const-oid = { version = "0.10.0-rc.0", features = ["db"] } | ||
| der = { version = "0.8.0-rc.0", features = ["alloc", "derive", "flagset", "oid"] } | ||
| der = { version = "0.8.0-rc.1", features = ["alloc", "derive", "flagset", "oid"] } |
Member
There was a problem hiding this comment.
This is not necessary, this is already tracked in the Cargo.lock
Member
|
Can we get back to that once #1689 merges? |
tarcieri
changed the title
builder feature activations
tarcieri
approved these changes
Mar 21, 2025
Member
|
@MihaelBercic could you rebase this? |
…efault feature from sha1 (includes std).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I was unable to run all tests due to not having the
zlintinstalled.