base64ct: Don't fail with InvalidLength when reading nothing at end of data#1716
Merged
tarcieri merged 2 commits intoRustCrypto:masterfrom Mar 13, 2025
Merged
Conversation
Since base64ct 1.7.0 ([RustCrypto#1387]), it now rejects zero lengths reads. This happens to trigger with an sha256WithRSAEncryption AlgorithmIdentifier where the parameters are null.
Member
Author
|
This is placed on part of #1711 (only its tests) to prove it doesn't re-introduce the regression. |
tarcieri
approved these changes
Mar 13, 2025
Member
|
I guess #1711 can be closed in favor of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another take on #1714
That brings back the original fix, but does not reject with
InvalidLengthwhen the out buffer is empty.